Cleanup / validate global exports. #16467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove unused legacy global flags. * Move imports "to the top" * Bring back `Ember.NAME_KEY` * Ensure all `computed.*` exports are setup in reexports test * Have `ember-metal/libaries` register the `Ember` library
ursm
added a commit
to ursm/ember-inflector
that referenced
this pull request
Apr 13, 2018
Several flags (including EXTEND_PROTOTYPES) underneath the Ember namespace have been removed in 3.1. emberjs/ember.js#16467
ursm
added a commit
to ursm/ember-inflector
that referenced
this pull request
Apr 13, 2018
Several flags (including EXTEND_PROTOTYPES) underneath the Ember namespace have been removed in Ember 3.2. emberjs/ember.js#16467
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember.NAME_KEYcomputed.*exports are setup in reexports testWith this PR all unconditional global exports are tested. The goal after this lands is to move the global export generation code to be auto-generated at build time...