Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using legacy global flags #144

Merged
merged 1 commit into from
Apr 20, 2018

Conversation

ursm
Copy link
Contributor

@ursm ursm commented Apr 13, 2018

Several flags (including EXTEND_PROTOTYPES) underneath the Ember namespace have been removed in Ember 3.2.
emberjs/ember.js#16467

Fixed #142

Several flags (including EXTEND_PROTOTYPES) underneath the Ember namespace have been removed in Ember 3.2.
emberjs/ember.js#16467
@ursm
Copy link
Contributor Author

ursm commented Apr 14, 2018

Ember.EXTEND_PROTOTYPES has been restored for a while, but I think that ember-inflector should not use this because it is deprecated.
emberjs/ember.js#16514

@ef4
Copy link

ef4 commented Apr 20, 2018

@rwjblue or @stefanpenner can I merge and release this? Anybody with ember-data trying to test against beta or canary has this deprecation and can't fix it themselves.

@rwjblue rwjblue merged commit ba8f54f into emberjs:master Apr 20, 2018
@ef4
Copy link

ef4 commented Apr 20, 2018

Thanks, I confirmed that this fixed my builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants