Instrument event dispatcher (rebased) #12550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -542,6 +553,8 @@ var EmberRouter = EmberObject.extend(Evented, { | |||
| emberRouter.didTransition(infos); | |||
| }; | |||
|
|
|||
| // TODO | |||
| //router.willTransition = this.willTransition.bind(this); | |||
There was a problem hiding this comment.
Hm, I think this was us saying we should just replace the line below with a bind since that's exactly what it was doing, but maybe we didn't want to change unrelated code in the commit
chancancode
force-pushed
the
instrument-event-dispatcher
branch
2 times, most recently
from
3b52aeb
to
5740168
Compare
|
Looks like this needs a rebase. |
chancancode
force-pushed
the
instrument-event-dispatcher
branch
from
5740168
to
29b29ff
Compare
|
Seems inoffensive, but does lack any tests for the action and routing instrumentation. |
This commit adds instrumentation for interaction events handled by components. The `before` hook of the instrumentation runs right before the component’s event handler is invoked, and the `after` hook runs right after it is invoked.
This commit instruments closure actions.
This instruments the start and end of top-level routing transitions. It does not run for redirects or intermediate transitions. There are two events: `router.transition.url` (payload contains the URL) and `router.transition.named` (payload contains the route name). The current implementation does not properly handle top-level transitions that never complete at all; this requires a fix to router.js.
chancancode
force-pushed
the
instrument-event-dispatcher
branch
from
29b29ff
to
637bd2b
Compare
chadhietala
added a commit
to chadhietala/ember.js
that referenced
this pull request
Feb 26, 2016
8 tasks
|
There is a very long trail on this one:
Closing this version for now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #12088