Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instrument event dispatcher (rebased) #12550

Closed
wants to merge 4 commits into from
Closed

Instrument event dispatcher (rebased) #12550

wants to merge 4 commits into from

Commits on Nov 5, 2015

  1. Instrument interaction events 

    This commit adds instrumentation for interaction events handled by
components. The `before` hook of the instrumentation runs right before
the component’s event handler is invoked, and the `after` hook runs
right after it is invoked.
    @chancancode
    Godhuda authored and chancancode committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    61c03ad View commit details
    Browse the repository at this point in the history

  2. [WIP] Add instrumentation for closure actions 

    This commit instruments closure actions.
    @chancancode
    Godhuda authored and chancancode committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    d484b7b View commit details
    Browse the repository at this point in the history

  3. Instrument routing transitions 

    This instruments the start and end of top-level routing transitions. It
does not run for redirects or intermediate transitions.

There are two events: `router.transition.url` (payload contains the URL)
and `router.transition.named` (payload contains the route name).

The current implementation does not properly handle top-level
transitions that never complete at all; this requires a fix to
router.js.
    @chancancode
    Godhuda authored and chancancode committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    d3775ef View commit details
    Browse the repository at this point in the history

  4. Make asyncInstrumentation private for now

    @chancancode
    chancancode committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    637bd2b View commit details
    Browse the repository at this point in the history