Add action and dom event instrumentation #13279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #13285) made this pull request unmergeable. Please resolve the merge conflicts. |
| @@ -8,6 +8,7 @@ | |||
| "ember-metal-ember-assign": true, | |||
| "ember-htmlbars-local-lookup": true, | |||
| "ember-application-engines": null, | |||
| "ember-glimmer": null | |||
| "ember-glimmer": null, | |||
| "ember-improved-instrumentation": true | |||
There was a problem hiding this comment.
This should be null in the PR.
This was referenced Apr 10, 2016
asakusuma
force-pushed
the
action-instrumentation
branch
4 times, most recently
from
a83d44c
to
e80b7b5
Compare
asakusuma
force-pushed
the
action-instrumentation
branch
from
e80b7b5
to
ee67815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the action and dom instrumentation part copied and merged over from @chadhietala's PR here: #13017
This is the highest priority part for getting us off of private APIs for tracking.
I noticed that some of the tests seem to be disabled for glimmer2, so I'm wondering what I need to do to get this working and tested with glimmer2.
cc @krisselden