Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a /current route that we can use in various places #185

Closed
acorncom opened this issue Mar 23, 2017 · 9 comments · Fixed by #209
Closed

Add a /current route that we can use in various places #185

acorncom opened this issue Mar 23, 2017 · 9 comments · Fixed by #209

Comments

@acorncom
Copy link
Member

At times we need the ability to link to "the most current" version of api docs (see #184 for an example). We need to add a /current route to this Ember app that will display the most current version of the api docs.

@MartinMalinda
Copy link
Contributor

MartinMalinda commented Mar 27, 2017

It could be implemented by sorting projectVersions with something like https://github.com/ragingwind/semver-sort. But maybe it would be better to sort it already in jsonapi-docs project. It would probably be more efficient.

@sivakumar-kailasam
Copy link
Member

we already have an array of sorted versions based on semver. We just need to handle /ember/current/ in the route load the latest one 😄

@MartinMalinda
Copy link
Contributor

MartinMalinda commented Mar 27, 2017

It does not seem to be sorted here: https://ead-sk.global.ssl.fastly.net/rev-index/ember.json. Maybe I am looking at a wrong place?

@sivakumar-kailasam
Copy link
Member

Oh its done part of the app in that route's controller

@MartinMalinda
Copy link
Contributor

MartinMalinda commented Mar 27, 2017

I see, that's great then. I will use that :). Probably will have to move it to the model though.

@acorncom acorncom modified the milestones: v0.5, MVP Mar 27, 2017
@toddjordan toddjordan modified the milestones: v1, v0.5 Apr 3, 2017
@toddjordan
Copy link
Contributor

Would be cool instead of or in addition to /current, to have /release, /lts, and maybe eventually /beta and /canary

@Gaurav0
Copy link
Contributor

Gaurav0 commented Apr 3, 2017

Hopefully /current and /release are the same.

@toddjordan
Copy link
Contributor

correct, though I feel like "release" would be clearer to what "current" means. Current could mean canary or beta or lts as well.

@acorncom acorncom modified the milestones: v1, v1.1, Future Apr 13, 2017
@MartinMalinda
Copy link
Contributor

Maybe we should reopen this? I will revisit this once the route structure refactor is merged.

Gaurav0 pushed a commit to Gaurav0/ember-api-docs that referenced this issue Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants