Handle /release requests #209
Conversation
|
@MartinMalinda I'm unsure how but would it be possible to research on how the /cuurent paths show up on search engine results first? |
|
@sivakumar-kailasam I think I read that there is a plan to have |
|
But besides that, if the guides and external sources will mostly link to
|
Yes, I think that's what we're going to need to do. We'll likely just handle that via a |
|
Do bots lookup robots file in subpaths too? |
|
@sivakumar-kailasam Don't believe |
|
@MartinMalinda I imagine you're just starting to recover from EmberConf like the rest of us 😀 But thought I'd poke my head in here to see if we need to do anything else here? Was talking to Robert Jackson and seems like it might be wiser to shift to a |
|
Yeah, I got excited by Glimmer and invested my "evening/weekend" time into it lately :). I'll try to finish this PR in upcoming days though. Moving from |
|
@MartinMalinda I can see how we can add it to the model but we can probably just hardcode it in the app as a config value given that it changes only few times a year. |
app/helpers/url-param.js
Outdated
|
|
||
| export default Ember.Helper.extend({ | ||
|
|
||
| '-routing': inject.service(), |
There was a problem hiding this comment.
May be we can use https://github.com/kellyselden/ember-router-service?
config/environment.js
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| module.exports = function(environment) { | |||
| var ENV = { | |||
| ltsVersion: '2.8.3', | |||
There was a problem hiding this comment.
Should we consider having short circuit to a env variable? That'd probably make it easier to restart app without having to elevate he app.
MartinMalinda
force-pushed
the
current-version
branch
from
f1bd640
to
7453459
Compare
MartinMalinda
changed the title
|
one thing I noticed is if you go to /release it gets redirected, but if you go to /release//, it keeps the release in the path. Is redirecting when just going to /release intentional? |
|
otherwise looks good. I'm going to merge and we can update later if need be. |
This reverts commit ffd2eb5.
This reverts commit ffd2eb5.
…ay-helper Add guide for `array` helper
should fix #185