Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect old urls to the corresponding page in the new viewer #184

Closed
1 of 5 tasks
acorncom opened this issue Mar 23, 2017 · 7 comments
Closed
1 of 5 tasks

Redirect old urls to the corresponding page in the new viewer #184

acorncom opened this issue Mar 23, 2017 · 7 comments
Assignees

Comments

@acorncom
Copy link
Member

acorncom commented Mar 23, 2017

PRs for this issue can be explored simultaneously with #185 and #216, but the solution for this is blocked until we have clarity on both:

Before we shift out of beta and replace the main api docs pages on the Ember website, we need to ensure that we've properly remapped all old api urls to their corresponding pages in the new Ember app. Some of our namespaces (as shown on the old sidebar) actually have the word classes in their url, and we'll need to account for that

Example urls that we'll want to redirect:

To do:

@acorncom acorncom added this to the v1 milestone Mar 23, 2017
@acorncom acorncom changed the title Get old urls setup to redirect to the corresponding page in the new viewer Redirect old urls to the corresponding page in the new viewer Mar 23, 2017
@sivakumar-kailasam
Copy link
Member

the rewrite engine should probably be fed a map based on 2.12's docs since some urls will have to land at ember and others at ember-data.

@toddjordan
Copy link
Contributor

We possibly also need a strategy for redirecting # method, property, and event links to the current strategy of url params. Either that or support hash based navigation in the new app as well.

@acorncom
Copy link
Member Author

@sivakumar-kailasam Confirmed on the mapping. My impression as I look at our url structure though is that we may not need a complete mapping, but may be able to handle a simpler set of wildcard rules that handle things.

@acorncom
Copy link
Member Author

Also opened a new issue for us to track info on @toddjordan's comment above

@acorncom acorncom self-assigned this Apr 13, 2017
@toddjordan
Copy link
Contributor

Supporting legacy module URLs: #242

@toddjordan
Copy link
Contributor

toddjordan commented Jul 6, 2017

Also #249 and #253 take a client side approach to handling legacy urls. Will transition any old url to the equivalent in the latest version

@toddjordan
Copy link
Contributor

not quite how written up, but /api is live now 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants