-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Nuxt 3.10.2 #2603
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
Hey @userquin ; @danielroe ; Just noticed your PR on @vueuse/gesture; I just released Could you let me know if that adresses your current issues with the package? Happy to help about anything on |
Yes, the new version fixes the problem with Bundler thx ❤️ |
Tests failing because the mock not being loaded and so missing |
I'm going to split this PR in 6:
|
This PR requires a review and includes:
LocaleObject
andDirections
from@nuxtjs/i18n
): update all required types and moved the configuration to the new i18n optionsisHydrated
to avoid hydration missmatch (also some setting pages updated to removeisHydrated
): talking with @patak-dev we need to review theisHydrated
, but I guess we cannot remove it since we'veapp.keepAlive
0.19.0
, I will do a full review tmrmodule resolution set tonode
: we need a fix for@vueuse/gesture
, cannot be used withBundler
: @danielroe sent a PR to the repo build: use unbuild v2 to emit.d.mts
files vueuse/gesture#25 (@antfu maybe you can do something on the repo: I have sent also a PR to fix types in@vueuse/motion
, we don't use the nuxt module but it can be a problem if we enable it here fix: types vueuse/motion#175)@nuxt/test-utils
(1.2.2
)process.client
,process.server
andprocess.dev
withimport.meta.client
,import.meta.server
andimport.meta.dev
respectivelly, we also need to reviewprocess.test
(it is configured invite.define
)typescheck
script should be fine, on my local worksThe problem with the browser was the
AccountHoverWrapper.vue
, we need to defer the account fetch until visible via interceptor observer when providing only the account handle.Also fixed the paginator module, changing the state to shallowRef to avoid multiples calls from the watch effect.
We also need to review page lifecycle again, switching between tabs reloading the page when back to elk tab.
supersedes #2543