Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to Nuxt 3.10.2 #2603

Closed
wants to merge 13 commits into from
Closed

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 22, 2024

This PR requires a review and includes:

  • update to nuxt 3.10.2
  • update to i18n 8.1.1 (some types moved to the module: LocaleObject and Directions from @nuxtjs/i18n): update all required types and moved the configuration to the new i18n options
  • update a lot of pages that now requires isHydrated to avoid hydration missmatch (also some setting pages updated to remove isHydrated): talking with @patak-dev we need to review the isHydrated, but I guess we cannot remove it since we've app.keepAlive
  • pwa not yet tested: updated pwa plugin to latest 0.19.0, I will do a full review tmr
  • module resolution set to node: we need a fix for @vueuse/gesture, cannot be used with Bundler: @danielroe sent a PR to the repo build: use unbuild v2 to emit .d.mts files vueuse/gesture#25 (@antfu maybe you can do something on the repo: I have sent also a PR to fix types in @vueuse/motion, we don't use the nuxt module but it can be a problem if we enable it here fix: types vueuse/motion#175)
  • vitest version fixed, the same using @nuxt/test-utils (1.2.2)
  • changed all process.client, process.server and process.dev with import.meta.client, import.meta.server and import.meta.dev respectivelly, we also need to review process.test (it is configured in vite.define)
  • rn typescheck script should be fine, on my local works

The problem with the browser was the AccountHoverWrapper.vue, we need to defer the account fetch until visible via interceptor observer when providing only the account handle.

Also fixed the paginator module, changing the state to shallowRef to avoid multiples calls from the watch effect.

We also need to review page lifecycle again, switching between tabs reloading the page when back to elk tab.

supersedes #2543

Copy link

stackblitz bot commented Feb 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit ef70a22
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65d7942b99f85000082bb246

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit ef70a22
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65d7942b3ab3b40008b14078
😎 Deploy Preview https://deploy-preview-2603--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented Feb 22, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@antfu/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +106 24 MB antfu
npm/@antfu/[email protected] environment, filesystem, shell 0 465 kB antfu
npm/@iconify/[email protected] Transitive: environment, filesystem, shell +9 671 kB cyberalien
npm/@nuxt-themes/[email protected] Transitive: environment, eval, filesystem, network +70 13.5 MB atinux
npm/@nuxt/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +39 11.1 MB danielroe
npm/@nuxtjs/[email protected] eval Transitive: environment, filesystem, network, unsafe +52 13.5 MB rchl
npm/@pinia/[email protected] Transitive: environment, filesystem, network +23 1.5 MB posva
npm/@unlazy/[email protected] Transitive: environment, filesystem, network +23 1.51 MB johannschopplich
npm/@unocss/[email protected] Transitive: environment, filesystem, network, shell, unsafe +62 6.91 MB antfu
npm/@vue/[email protected] eval 0 1.5 MB lmiller1990
npm/@vueuse/[email protected] None +3 1.92 MB antfu, egoist, sxzz, ...1 more
npm/@vueuse/[email protected] Transitive: environment, filesystem +6 594 kB antfu, egoist, sxzz, ...1 more
npm/@vueuse/[email protected] None +7 3.34 MB antfu
npm/@vueuse/[email protected] None +1 359 kB antfu
npm/@vueuse/[email protected] environment +6 5.35 MB tahul
npm/[email protected] None 0 46.7 kB tomayac
npm/[email protected] None +2 548 kB akryum
npm/[email protected] None 0 637 kB stefcameron

🚮 Removed packages: npm/@antfu/[email protected], npm/@antfu/[email protected], npm/@iconify/[email protected], npm/@nuxt-themes/[email protected], npm/@nuxt/[email protected], npm/@nuxt/[email protected], npm/@nuxtjs/[email protected], npm/@pinia/[email protected], npm/@unocss/[email protected], npm/@vue/[email protected], npm/@vueuse/[email protected], npm/@vueuse/[email protected], npm/@vueuse/[email protected], npm/@vueuse/[email protected], npm/@vueuse/[email protected], npm/@vueuse/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

.vscode/settings.json Outdated Show resolved Hide resolved
composables/cache.ts Outdated Show resolved Hide resolved
composables/dialog.ts Outdated Show resolved Hide resolved
error.vue Outdated Show resolved Hide resolved
userquin and others added 2 commits February 22, 2024 18:29
Co-authored-by: Daniel Roe <[email protected]>
Co-authored-by: Daniel Roe <[email protected]>
@Tahul
Copy link

Tahul commented Feb 22, 2024

Hey @userquin ; @danielroe ;

Just noticed your PR on @vueuse/gesture; I just released 2.0.0.

Could you let me know if that adresses your current issues with the package?

Happy to help about anything on @vueuse/motion or @vueuse/gesture, and pleased to discover you are using these packages on Elk!

@userquin
Copy link
Member Author

Could you let me know if that adresses your current issues with the package?

Yes, the new version fixes the problem with Bundler

thx ❤️

@userquin
Copy link
Member Author

userquin commented Feb 22, 2024

Tests failing because the mock not being loaded and so missing currentServer

@userquin userquin marked this pull request as draft February 23, 2024 12:24
@userquin
Copy link
Member Author

userquin commented Feb 23, 2024

I'm going to split this PR in 6:

@patak-dev
Copy link
Member

Closing, as #2610 has now been merged.
Awesome work with these updates @userquin!

@patak-dev patak-dev closed this Feb 24, 2024
@userquin userquin deleted the userquin/chore-nuxt-3.10.2 branch February 24, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants