feat: bump to latest vue 3.4.19 #2607
Conversation
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| optimizeDeps: { | ||
| include: [ | ||
| '@tiptap/vue-3', 'string-length', 'vue-virtual-scroller', 'emoji-mart', 'iso-639-1', | ||
| '@tiptap/extension-placeholder', '@tiptap/extension-document', '@tiptap/extension-paragraph', | ||
| '@tiptap/extension-text', '@tiptap/extension-mention', '@tiptap/extension-hard-break', | ||
| '@tiptap/extension-bold', '@tiptap/extension-italic', '@tiptap/extension-code', | ||
| '@tiptap/extension-history', 'prosemirror-state', 'browser-fs-access', 'blurhash', | ||
| '@vueuse/integrations/useFocusTrap', '@tiptap/extension-code-block', 'prosemirror-highlight', | ||
| '@tiptap/core', 'tippy.js', 'prosemirror-highlight/shiki', '@fnando/sparkline', | ||
| '@vueuse/gesture', 'github-reserved-names', 'file-saver', 'slimeform', 'vue-advanced-cropper', | ||
| 'workbox-window', 'workbox-precaching', 'workbox-routing', 'workbox-cacheable-response', | ||
| 'workbox-strategies', 'workbox-expiration', | ||
| ], | ||
| }, |
There was a problem hiding this comment.
We could probably remove the ones that would be detected by the scanner, but I think it is ok for now to include all of these 👍🏼
There was a problem hiding this comment.
Some dependencies only detected when matching the case: for example, github-reserved-names and file-saver when visiting the settings > users and about pages
When visiting a new page and found a new entry in the console I just add them to the list.
| const [_oldAccount, oldHandle, _oldVisible] = oldProps ?? [undefined, undefined, false] | ||
| if (!oldHandle || newHandle !== oldHandle || !account.value) { | ||
| // @ts-expect-error just ignore | ||
| useAccount.value = useAccountByHandle(newHandle) |
There was a problem hiding this comment.
Should we remove useAccountByHandle and do a fetch here directly as we discussed?
|
If |
To make that change we need to remove all imports, including
|
There was a problem hiding this comment.
Looks great! Thanks for the hard work to make this happen @userquin 👏🏼
@danielroe I think we should merge it. I'll leave it open for a bit in case you would like to check it out. We can remove other isHydrated conditionals in a future PR (I see there are some already removed here, and it is ok). The Nuxt update should be a manageable PR now.
There was a problem hiding this comment.
Given that the isHydrated conditionals changes are now contained, I think we can move forward and merge this PR. If later on we find out a way to avoid these, there isn't the need for a big revert like before.
We discussed with @userquin that it would be ideal if the server will know somehow the language (like we do with the theme color?) so it can directly render the proper strings and avoid the need for the t wrappers.
There is also a half fix for #2601 included.
Co-authored-by: patak <[email protected]>
Co-authored-by: patak <[email protected]>
This PR includes:
AccountHoverWrapper.vueCommonRouteTabs.vueto~/typesand update all components using those typesuseI18nto provideisHydratedvariants oft,dandn$t,$dand$nto provideisHydratedvariantsinclude: reverted someisHydratedlogic in all pages and componentsisHydratedsince we have included the custom versionsWe need to review and update all
isHydrated,t,d,n,$t,$dand$nusages in vue sfc and ts modules: will be included in another PR.