chore: cleanup isHydrated #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for elk-docs canceled.
|
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
userquin
changed the title
userquin
changed the title
|
Would you split the wrong tabindex usage and the HelpPreview change to two separate PRs from the isHydrated removal? 🙏🏼 |
userquin
changed the title
patak-dev
approved these changes
Feb 24, 2024
shuuji3
pushed a commit
to shuuji3/elk
that referenced
this pull request
Feb 29, 2024
Co-authored-by: patak <[email protected]>
shuuji3
pushed a commit
to shuuji3/elk
that referenced
this pull request
Feb 29, 2024
Co-authored-by: patak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes:
HelpPreviewto focus close button once shown adding type button to enter and close buttons: moved to fix(ui): help preview tabindex, auto focus and buttons #2616