Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting MIX_TARGET for a project #108

Merged
merged 1 commit into from
Jun 21, 2020

Conversation

jjcarstens
Copy link
Contributor

Will be utilized in elixir-lsp/elixir-ls#299

@aj-foster
Copy link
Contributor

Hello there 👋

I'm not a maintainer or anything, but over in #58 and #110 we've been discussing stuff related to the scope key for configuration settings. TL;DR it's my belief that a scope of resource might be appropriate for most of this extension's settings. More info available here.

Just a thought. Thanks for jumping in with this PR. 🙂

@jjcarstens
Copy link
Contributor Author

Thanks @aj-foster! I just added "scope": "resource" to the definition. How does it look?

@aj-foster
Copy link
Contributor

That looks great to me! Hopefully that will help someone using multi-project workspaces while working on something that needs a target.

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ❤️

And thanks @aj-foster for catching this PR (to keep it consistent with scope usage

@axelson axelson merged commit 518006a into elixir-lsp:master Jun 21, 2020
@jjcarstens jjcarstens deleted the mix-target branch July 24, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants