Support setting MIX_TARGET #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For elixir-lsp#248 This allows you to set MIX_TARGET in a config and have it used in Elixir versions >= 1.8 This is most often used with Nerves and removes a lot of compilation errors in repos relying on a target to be set
jjcarstens
added a commit
to jjcarstens/vscode-elixir-ls
that referenced
this pull request
Jun 17, 2020
Will be utilized in elixir-lsp/elixir-ls#299
| if function_exported?(Mix, :target, 0) do | ||
| # Even though we know we have the function here, | ||
| # Compilation will fail calling Mix.target/0 directly | ||
| # since Elixir 1.7 is used to compile - So we get around |
There was a problem hiding this comment.
Maybe it's time we dropped support for 1.7
There was a problem hiding this comment.
This was brought up in the original issue, but ultimately decided that things weren't ready to drop the minimum to away from 1.8 - But I'm definitely open to suggestions about making this workaround look better if desired?
axelson
approved these changes
Jun 21, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #248
This allows you to set MIX_TARGET in a config and have it used in Elixir versions >= 1.8
This is most often used with Nerves and removes a lot of compilation errors in repos relying on a target to be set
I used this little target_test to test and everything seemed to work as expected (built for the target and errors/warnings went away 🙌 )