Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-folder configuration in multi-root workspaces #110

Merged
merged 1 commit into from
Jun 21, 2020
Merged

Allow per-folder configuration in multi-root workspaces #110

merged 1 commit into from
Jun 21, 2020

Conversation

aj-foster
Copy link
Contributor

@aj-foster aj-foster commented Jun 17, 2020

This PR modifies the scope of several configuration settings offered by the extension. The goal of the changes is to allow settings to be modified on a per-project basis while operating in a multi-root workspace.

Relevant documentation can be found under the scope heading in the Configuration schema section here.

The following checklist marks the configuration settings I've manually tested to ensure they are respected at the folder level: (Edit: all set.)

  • dialyzerEnabled
  • dialyzerWarnOpts
  • dialyzerFormat
  • mixEnv
  • projectDir
  • fetchDeps
  • suggestSpecs

As always, there may be unforeseen consequences to using the settings at this scope. Happy to help diagnose. 🙂

Addresses #58.

Copy link
Member

@axelson axelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! ❤️

@axelson axelson merged commit 44d0bca into elixir-lsp:master Jun 21, 2020
@bruno-azenha
Copy link

I also love this.
:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants