-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTP 26 support #923
OTP 26 support #923
Conversation
make sure that io_request is handled before exiting
on OTP 26 somehow this results in setopt request being sent to OutputDevice with not supported options causing it to crash
Nice to see that you got it working! Just a note that intercepting |
@garazdawi What we do here is intercept standard IO so everything written to stdout and stderr is wrapped in LSP protocol messages, serialized to JSON and printed to stdout in binary. See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#baseProtocol for details. The reason we do the interception is we don't have control over what build plugins/tools/libs print to std and each message printed that is not LSP breaks the communication channel. |
Sure, but we haven't done many changes to the shell and its tools in the last 10+ years. We have however now started to do much more work in that area and the more tools that rely on undocumented and untested behavior, the more things we will accidentally break.
That's what I thought was going on, thanks for confirming. I'll have a think about how we can create an official API for you to use inorder to intercept user output. |
First release with support for Erlang/OTP 26. 26.0.2 or later required. https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.15.1 elixir-lsp/elixir-ls#886 elixir-lsp/elixir-ls#923
No description provided.