Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elixir_ls: 0.14.6 -> 0.15.1 #241108

Merged
merged 1 commit into from
Jul 3, 2023
Merged

elixir_ls: 0.14.6 -> 0.15.1 #241108

merged 1 commit into from
Jul 3, 2023

Conversation

shanesveller
Copy link
Contributor

@shanesveller shanesveller commented Jul 2, 2023

Description of changes

First LSP release with proper support for Erlang/OTP 26. 26.0.2 or later required for actual use.

For more info:
https://github.com/elixir-lsp/elixir-ls/releases/tag/v0.15.1
elixir-lsp/elixir-ls#886
elixir-lsp/elixir-ls#923

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@happysalada
Copy link
Contributor

Thank you !

@happysalada
Copy link
Contributor

This is still marked as draft, do you have more changes planned or do you want to do more testing ?

@shanesveller
Copy link
Contributor Author

This is still marked as draft, do you have more changes planned or do you want to do more testing ?

I forgot to circle back after doing said testing 😸

@shanesveller shanesveller marked this pull request as ready for review July 3, 2023 01:00
@happysalada happysalada merged commit b5eafe6 into NixOS:master Jul 3, 2023
11 checks passed
@MartinElvar
Copy link

After updating my elixir-ls has stopped working. I'm getting the following when running it.

running /nix/store/f2sgzwbiz6s963zw0z4ssamskz2jyxag-elixir-ls-0.15.1/bin/launch.sh
Looking for ASDF install in /home/saturn/.asdf/asdf.sh
Content-Length: 103

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Started ElixirLS v0.15.1","type":3}}Content-Length: 115

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Running in /home/saturn/nixos-config","type":3}}Content-Length: 130

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"ElixirLS built with elixir \"1.15.2\" on OTP \"25\"","type":3}}Content-Length: 151

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Running on elixir \"1.15.2 (compiled with Erlang/OTP 25)\" on OTP \"25\"","type":3}}Content-Length: 109

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Protocols are not consolidated","type":3}}Content-Length: 176

{"jsonrpc":"2.0","method":"window/logMessage","params":{"message":"Elixir sources not found (checking in /build/source). Code navigation to Elixir modules disabled.","type":3}}

@shanesveller shanesveller deleted the shanesveller/elixir-ls-0.15.1 branch July 13, 2023 15:47
@shanesveller
Copy link
Contributor Author

@MartinElvar I took a very brief look at the 0.15.1 changelog and nothing struck me as obviously related to what you're seeing. Could you please review the open issues upstream and perhaps create one on the elixir-ls board to see if it is a problem the authors recognize?

Two wrinkles I can volunteer now - I do not use asdf-elixir or have it installed, but I have a project on OTP 26.0.2 / Elixir 1.15.2 that has a working elixir-ls experience for me using this definition. The caveat is that I am deliberately rebuilding the elixir-ls derivation using those specific Erlang/Elixir inputs when I use it with that particular project. The Nix code in question starts here, but if someone follows it down through the abstractions I wrote locally and with flake-parts help, it's roughly equivalent to something like this:

with nixpkgs; (beam.packagesWith beam.interpreters.erlang_26).elixir-ls.override { elixir = beam.interpreters.elixir_1_15; }

@MartinElvar
Copy link

Hello @shanesveller,

Thanks for taking the time to reply to me. I'm not using asdf either, but i guess the log about is only for information. I've tried to force a specfic version of elixir in the elixir-ls by doing the following.

    packages = with pkgs; [
      ... packages 
    ] ++ (
      let 
       elixir-ls = pkgs.elixir_ls.override {
         elixir = elixir_1_15;
      };
    in [
      elixir-ls
    ]);

I see that elixir_1_15 is compiled with OTP 25 and not 26, could this be the issue?
Do i somehow need to specify the elixir path for elixir-ls now? Just wondering by the looks of the error Elixir sources not found (checking in /build/source).

@happysalada
Copy link
Contributor

The upgrade of the default erlang version from 25 to 26 has to be done at some point, but since it needs a bit of testing stuff, no one really has had the time for it.

@DianaOlympos
Copy link
Contributor

I will have a look this weekend, most of the problems should be fixed by now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants