-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not starting on OTP26 #886
Comments
Hi, I just wanted to add that it does not work with the released version of Erlang 26.0.
|
New version caused breaking changes in 'elixir-ls'. Downgrading for now. Ref elixir-lsp/elixir-ls#886
until resolved: elixir-lsp/elixir-ls#886
Even with the OTP26 branch with master merged in things are working much, much better ;) |
It crashes on first utf character in client request |
I see one crash, and then it seems to work fine after that.. (where previously it would just crash repeatedly.) Not saying it's fixed. But it's actually usable right now for me... |
FYI, the last open bug in OTP 26 has just been closed 🎉 |
Now we need an OTP release OTP-26.0.2 with the fix and find a way how to pass |
It would be great if you could test the latest |
Elixir 1.15.0 (compiled with Erlang/OTP 26) Just compiled and installed maint and getting the following error:
This is with what sounds to a the fix: erlang/otp@bf1916d with the flag set as I also tested the credo-language-server over stdio which is working as expected. |
On macOS 12.6/arm64 I get:
Wonder how or where you can set the path for the Elixir source… but I think it's our last problem here ;) |
Instead of posting the same crash log again and again what would actually help here would be testing the new flag added on OTP master. |
Nope. With the Otp master from today (2023-06-25 18:45 CEST):
Unfortunately, the process crashes very similar fashion as before. |
Are you running with --erl "-kernel standard_io_encoding latin1"? Also OTP26 branch has other changes that may be needed |
I added |
Fixed in #923 |
@lukaszsamson I uninstalled ElixirLS in VSCodium but it didn't remove the folder
I don't know whether this is because I'm using VSCodium and they get their release assets from another place or whether there is some kind of extension release asset cache in VSCode that prevents it from downloading the new release asset. |
You are installing the wrong version once again. VSCode plugin versioning is independent from elixirLS versioning. You need 0.15.2 https://github.com/elixir-lsp/vscode-elixir-ls/blob/master/CHANGELOG.md#v0152-29-june-2023 |
It looks like the newest version available is 0.15.1:
So I probably have to install it like described in the installation section of the README because it didn't get released yet? Sorry for the turmoil but because of the vscode extension version 0.15.1 I thought that I'm installing ElixirLS 0.15.1 all the time. |
Thank you @lukaszsamson for your patience. Since these issues are not related to ElixirLS itself, they could be moved to the vscode-elixir-ls repository, if there is indeed an issue? |
I've done a fix for the Windows issue in erlang/otp#7473. Would be great if you could test that both Unix and Windows still work as they should for ElixirLS. |
Fix merged, but I'll hold of making a patch until I get confirmation here (or in erlang/otp#7473) that the fix solves the issue and that no new ones have popped up. |
Maybe this should be pinned to the top of Open Issues, and maybe the title should be renamed to "elixlir-ls on OTP26 does not work in VSCode" or "Don't upgrade to OTP26 with VSCode". I'm new to Elixir (so I haven't upgraded from a previous version), and it took me some time to:
i.e. for someone new to Elixir, being a bit more explicit about the problem would be helpful |
@dr1ver1 It is already pinned since OTP 26 rc.3 release and mentioned both in release notes and README. There were at least ten threads on the forum and messages on slack. It does not stop people from running on incompatible versions and raising issues... |
ok. I was looking through issues at https://github.com/elixir-lsp/vscode-elixir-ls/issues |
@dr1ver1 I've added a pinned issue to that repo for additional visibility: elixir-lsp/vscode-elixir-ls#365 |
Hello, This is my error message when running in emacs with lsp-mode:
|
@jschaeff Please make sure you run OTP >= 26.0.2 |
Yes it's OTP 26.0.2 |
Please post more logs. Can you create a dockerfile that reproduces it? |
Latest version of elixir-ls (v0.16.0) runs without problems on Linux with the following versions:
|
OTP 26.1 is out with the fix for erlang/otp#7459, I'll test it out later |
It's hard to make a docker container that mimic's the dialog between emacs lsp-mode and elixir-ls, but it lead me to another path: Sidenote: It's also a bit weird that archlinux is so much behind in the elixir package (1.15.0) |
I have just tested erlang 26.1/elixir 1.15.4 with 0.16 in one of my projects, it works but some vim restarts were necessary. |
I'm curious, why wait for the release to test it? If you had tested my PR and confirmed that it fixed the problem I would have released a patch with this fix 2 months ago. |
I can confirm that elixir-ls 0.16 with OTP 26.1 is working on windows
Let's put it like this: building OTP on windows isn't the easiest of tasks |
Each PR opened towards our repository creates an .exe installer that can be used for testing. There is link to it in the auto-generated comment: erlang/otp#7473 (comment) |
I'm closing the issue as now all main OSes are working with OTP 26 |
Another OTP related issue #1023 |
There are several issues that make ElixirLS fail on OTP26. Some of them are already addressed on https://github.com/elixir-lsp/elixir-ls/tree/otp26 but some will need to wait for fixes upstream
The text was updated successfully, but these errors were encountered: