Skip to content

Clean up cold email modal#827

Merged
elie222 merged 4 commits intomainfrom
feat/cold-email-settings-cleanup
Oct 3, 2025
Merged

Clean up cold email modal#827
elie222 merged 4 commits intomainfrom
feat/cold-email-settings-cleanup

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Oct 2, 2025

Summary by CodeRabbit

  • Style

    • Updated Cold Email Settings UI: replaced the selection control with a dropdown and the digest checkbox with a toggle, with a cleaner, streamlined layout.
  • New Features

    • Added inline error messages directly beneath relevant controls for clearer feedback.
  • Refactor

    • Simplified underlying components to support the new controls and layout without changing form behavior.
  • Chores

    • Bumped version to v2.13.3.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Replaces ColdEmailSettings UI: swaps RadioGroup for a Select component for coldEmailBlocker and replaces a checkbox with a Toggle for coldEmailDigest, adds inline error messaging, adjusts layout, removes the shared RadioGroup component file, and bumps version from v2.13.2 to v2.13.3.

Changes

Cohort / File(s) Summary of Changes
Cold email settings UI update
apps/web/app/(app)/[emailAccountId]/cold-email-blocker/ColdEmailSettings.tsx
Replaced RadioGroup with Select for coldEmailBlocker; replaced checkbox with Toggle for coldEmailDigest; added inline error messaging; adjusted layout; maintained form submission wiring.
RadioGroup removal
apps/web/components/RadioGroup.tsx
Deleted generic RadioGroup component and related types; removed Headless UI-based radio rendering and associated error handling.
Version bump
version.txt
Updated version from v2.13.2 to v2.13.3.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant UI as ColdEmailSettings UI
  participant Form as RHF Form
  participant Backend as Submit Handler

  User->>UI: Open Cold Email Settings
  UI->>User: Show Select (blocker) + Toggle (digest)

  User->>UI: Choose blocker via Select
  UI->>Form: setValue(coldEmailBlocker)
  Note right of UI: Inline error shown if validation fails

  User->>UI: Toggle digest on/off
  UI->>Form: setValue(coldEmailDigest)

  User->>UI: Submit form
  UI->>Form: handleSubmit()
  Form->>Backend: Submit payload { blocker, digest }
  Backend-->>Form: Success or error
  Form-->>UI: Update state / show errors
  UI-->>User: Confirmation or inline errors
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • edulelis

Poem

A bunny toggles dawn to dusk—click, click!
Selects a path where radios once did pick.
Errors whisper softly, neatly shown,
Version hops a notch, carrots grown.
With UI spruced and forms aligned,
This rabbit signs: ship it, refined! 🥕✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/cold-email-settings-cleanup

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c85959 and 597db3d.

📒 Files selected for processing (3)
  • apps/web/app/(app)/[emailAccountId]/cold-email-blocker/ColdEmailSettings.tsx (2 hunks)
  • apps/web/components/RadioGroup.tsx (0 hunks)
  • version.txt (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Oct 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
inbox-zero Error Error Oct 3, 2025 0:40am

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

@elie222 elie222 changed the base branch from cursor/implement-mcp-integration-system-cc46 to main October 2, 2025 23:26
@elie222 elie222 merged commit 15d571d into main Oct 3, 2025
6 of 8 checks passed
@elie222 elie222 deleted the feat/cold-email-settings-cleanup branch December 18, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments