Add back cold email blocker digest

[elie222]

Summary by CodeRabbit

• New Features
  • Added support for managing a "Cold Emails" digest preference alongside existing rule-based digest preferences in account settings.
  • Introduced a toggle option for "Cold Emails" in the digest settings form.
  • Improved loading indicators with enhanced skeleton placeholders in digest-related forms.
• Bug Fixes
  • Unified loading and error handling for multiple data sources in the digest settings form.
• Chores
  • Updated app version to v1.9.8.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
inbox-zero	✅ Ready (Inspect)	Visit Preview	Jul 13, 2025 6:04pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces support for a "Cold Emails" digest preference across the application. It modifies the cold email blocker rule to conditionally include a digest action, extends settings forms and validation to manage the new preference, and updates the digest items action and UI to handle this option. The version is incremented.

Changes

File(s)	Change Summary
apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx	Adds a conditional digest action for the cold email blocker rule based on coldEmailDigest state.
apps/web/app/(app)/[emailAccountId]/settings/DigestItemsForm.tsx	Integrates "Cold Emails" digest toggle, fetches digest settings, adds UI component for toggles.
apps/web/app/(app)/[emailAccountId]/settings/DigestScheduleForm.tsx	Updates loading UI to use a skeleton component for consistency.
apps/web/utils/actions/settings.ts	Updates updateDigestItemsAction to accept and process coldEmailDigest.
apps/web/utils/actions/settings.validation.ts	Adds optional coldEmailDigest boolean to the validation schema.
version.txt	Increments version from v1.9.7 to v1.9.8.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DigestItemsForm
    participant API
    participant Rules
    participant SettingsAction

    User->>DigestItemsForm: Toggle "Cold Emails" digest
    DigestItemsForm->>API: Fetch rules and digest settings
    DigestItemsForm->>SettingsAction: Submit updated preferences (incl. coldEmailDigest)
    SettingsAction->>API: Update ruleDigestPreferences and coldEmailDigest
    API-->>SettingsAction: Success
    SettingsAction-->>DigestItemsForm: Mutate caches
    DigestItemsForm->>Rules: coldEmailDigest state updated
    Rules->>Rules: Conditionally add digest action to cold email blocker rule

Loading

Possibly related PRs

• Show cold email blocker as a rule #448: Integrates the cold email blocker as a distinct rule with special UI handling in the Rules component, directly related to logic changes here.
• Light sidebar #449: Introduces the cold email blocker rule with base actions and special UI handling; this PR builds on those features.
• feat: Digest e-mails #478: Implements digest email functionality and integrates digest toggles in onboarding and settings forms, closely related to digest preference handling.

Suggested reviewers

• edulelis

Poem

A toggle for cold emails, now in sight,
Digest options bloom, settings feel light.
A bunny hops through forms, with actions anew,
Skeletons shimmer while loading is due.
Version hops up, v1.9.8—
Inbox zero dreams, isn't that great? 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/[emailAccountId]/settings/DigestItemsForm.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/utils/actions/settings.ts

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

• 2 others

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0410596 and 8ba0c30.

📒 Files selected for processing (6)

• apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx (1 hunks)
• apps/web/app/(app)/[emailAccountId]/settings/DigestItemsForm.tsx (7 hunks)
• apps/web/app/(app)/[emailAccountId]/settings/DigestScheduleForm.tsx (2 hunks)
• apps/web/utils/actions/settings.ts (2 hunks)
• apps/web/utils/actions/settings.validation.ts (1 hunks)
• version.txt (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[claude]

Claude finished @elie222's task —— View job

---

Code Review for Cold Email Blocker Digest Feature

Review Tasks:

• Read repository guidelines (CLAUDE.md)
• Examine Rules.tsx changes
• Review DigestItemsForm.tsx modifications
• Analyze DigestScheduleForm.tsx updates
• Check settings.ts action changes
• Review validation changes
• Provide comprehensive feedback

---

✅ Overall Assessment

This PR successfully adds back cold email blocker digest functionality with a clean implementation. The changes are well-structured and follow existing patterns in the codebase.

📋 Summary of Changes

The PR adds digest functionality for cold emails by:

1. Adding a digest action to the cold email blocker rule when enabled
2. Including a "Cold Emails" toggle in the digest items form
3. Updating backend actions to handle the cold email digest setting
4. Adding proper validation for the new field

🔍 Detailed Review

Code Quality: ✅ Good

Strengths:

• Follows existing code patterns and conventions
• Good separation of concerns between UI and backend logic
• Proper TypeScript typing throughout
• Consistent error handling with toast notifications
• Clean component extraction (DigestItem) reduces code duplication

Improvements:

• Component organization is solid with the new DigestItem helper component

Potential Bugs: ⚠️ Minor Issues

1. Race Condition Risk (apps/web/app/(app)/[emailAccountId]/settings/DigestItemsForm.tsx:57-70):

   useEffect(() => {
     if (rules && digestSettings) {
       // Reset form when either rules OR digestSettings changes
     }
   }, [rules, digestSettings, reset]);

   The effect runs whenever either rules or digestSettings changes, potentially causing unnecessary form resets if one loads before the other.

2. Missing Null Checks (apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx:153):

   emailAccountData?.coldEmailDigest

   While the null-conditional operator is used, there's an assumption that if coldEmailDigest exists, it's truthy. Consider explicit boolean checking: emailAccountData?.coldEmailDigest === true

Performance: ✅ Good

Positives:

• Efficient use of useMemo for rules computation
• Proper use of useCallback for event handlers
• Smart loading states with skeleton components
• SWR caching for digest settings

Minor Optimization:

• The rules computation in Rules.tsx could benefit from more granular dependencies in the useMemo to avoid unnecessary recalculations

Security: ✅ Secure

Strong Points:

• Proper input validation with Zod schemas
• Authorization checks ensure rules belong to the correct email account (settings.ts:96-107)
• Server-side validation prevents unauthorized access
• No sensitive data exposure

Suggested Improvements

1. Improve Loading State Management (DigestItemsForm.tsx):

   // Consider separating the loading states
   const isLoading = rulesLoading || digestLoading;
   
   // Better approach:
   const canRender = !rulesLoading && !digestLoading && rules && digestSettings;

2. Add Default Value Protection (DigestItemsForm.tsx:67):

   coldEmailDigest: digestSettings?.coldEmail ?? false,

3. Consider Error Boundary for better error handling when both API calls fail

4. Optimize Rules Computation (Rules.tsx:92):

   const rules: RulesResponse = useMemo(() => {
     // Consider more specific dependencies
   }, [baseRules, emailAccountData?.coldEmailBlocker, emailAccountData?.coldEmailDigest, emailAccountId]);

🎯 Recommendations

1. Test Edge Cases: Ensure the form handles scenarios where one API call succeeds and another fails
2. Add Loading States: Consider more granular loading states for better UX
3. Documentation: The PR would benefit from a description explaining the feature

🚀 Final Verdict

✅ APPROVED - This is a solid implementation that follows good practices. The suggested improvements are minor optimizations rather than blocking issues. The code is production-ready and maintains consistency with the existing codebase.

---

[claude]

Claude finished @elie222's task —— View job

---

Code Review for Cold Email Blocker Digest Feature

Review Tasks:

• Read repository guidelines (CLAUDE.md)
• Examine Rules.tsx changes
• Review DigestItemsForm.tsx modifications
• Analyze DigestScheduleForm.tsx updates
• Check settings.ts action changes
• Review validation changes
• Provide comprehensive feedback

---

✅ Overall Assessment

This PR successfully adds back cold email blocker digest functionality with a clean implementation. The changes are well-structured and follow existing patterns in the codebase.

📋 Summary of Changes

The PR adds digest functionality for cold emails by:

1. Adding a digest action to the cold email blocker rule when enabled
2. Including a "Cold Emails" toggle in the digest items form
3. Updating backend actions to handle the cold email digest setting
4. Adding proper validation for the new field

🔍 Detailed Review

Code Quality: ✅ Good

Strengths:

• Follows existing code patterns and conventions
• Good separation of concerns between UI and backend logic
• Proper TypeScript typing throughout
• Consistent error handling with toast notifications
• Clean component extraction (DigestItem) reduces code duplication

Improvements:

• Component organization is solid with the new DigestItem helper component

Potential Bugs: ⚠️ Minor Issues

1. Race Condition Risk (apps/web/app/(app)/[emailAccountId]/settings/DigestItemsForm.tsx:57-70):

   useEffect(() => {
     if (rules && digestSettings) {
       // Reset form when either rules OR digestSettings changes
     }
   }, [rules, digestSettings, reset]);

   The effect runs whenever either rules or digestSettings changes, potentially causing unnecessary form resets if one loads before the other.

2. Missing Null Checks (apps/web/app/(app)/[emailAccountId]/assistant/Rules.tsx:153):

   emailAccountData?.coldEmailDigest

   While the null-conditional operator is used, there's an assumption that if coldEmailDigest exists, it's truthy. Consider explicit boolean checking: emailAccountData?.coldEmailDigest === true

Performance: ✅ Good

Positives:

• Efficient use of useMemo for rules computation
• Proper use of useCallback for event handlers
• Smart loading states with skeleton components
• SWR caching for digest settings

Minor Optimization:

• The rules computation in Rules.tsx could benefit from more granular dependencies in the useMemo to avoid unnecessary recalculations

Security: ✅ Secure

Strong Points:

• Proper input validation with Zod schemas
• Authorization checks ensure rules belong to the correct email account (settings.ts:96-107)
• Server-side validation prevents unauthorized access
• No sensitive data exposure

Suggested Improvements

1. Improve Loading State Management (DigestItemsForm.tsx):

   // Consider separating the loading states
   const isLoading = rulesLoading || digestLoading;
   
   // Better approach:
   const canRender = !rulesLoading && !digestLoading && rules && digestSettings;

2. Add Default Value Protection (DigestItemsForm.tsx:67):

   coldEmailDigest: digestSettings?.coldEmail ?? false,

3. Consider Error Boundary for better error handling when both API calls fail

4. Optimize Rules Computation (Rules.tsx:92):

   const rules: RulesResponse = useMemo(() => {
     // Consider more specific dependencies
   }, [baseRules, emailAccountData?.coldEmailBlocker, emailAccountData?.coldEmailDigest, emailAccountId]);

🎯 Recommendations

1. Test Edge Cases: Ensure the form handles scenarios where one API call succeeds and another fails
2. Add Loading States: Consider more granular loading states for better UX
3. Documentation: The PR would benefit from a description explaining the feature

🚀 Final Verdict

✅ APPROVED - This is a solid implementation that follows good practices. The suggested improvements are minor optimizations rather than blocking issues. The code is production-ready and maintains consistency with the existing codebase.

---