Skip to content

Show cold email blocker as a rule#448

Merged
elie222 merged 1 commit intomainfrom
feat/cold-email-blocker-as-rule
May 25, 2025
Merged

Show cold email blocker as a rule#448
elie222 merged 1 commit intomainfrom
feat/cold-email-blocker-as-rule

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented May 25, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a system-level cold email blocker rule, displayed alongside user-defined rules.
    • Special handling for the cold email blocker rule, including dedicated edit/history links, disabled toggles, and restricted menu actions.
  • User Interface

    • Updated rules list to dynamically include the cold email blocker rule when enabled, with distinct display and navigation behavior.

@vercel
Copy link

vercel bot commented May 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero ✅ Ready (Inspect) Visit Preview May 25, 2025 10:17am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 25, 2025

Walkthrough

A "cold email blocker" rule is integrated into the rules list within the automation UI. The component now dynamically constructs and appends this special rule based on email account settings, with unique rendering, navigation, and restricted actions, while maintaining existing behavior for user-defined rules.

Changes

File(s) Change Summary
apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx Added logic to append a cold email blocker rule based on account settings. Updated rendering and actions to handle this rule with special cases (navigation, toggles, dropdown actions).

Poem

A blocker for cold emails hops in today,
With rules and toggles tucked away.
Special links and menus, just for this guest,
While user-made rules behave like the rest.
In the garden of automations, new sprouts appear—
Rabbits rejoice, the inbox is clear!
🐇📧✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx

Oops! Something went wrong! :(

ESLint: 9.24.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx (1)

119-119: Consider using a more robust label extraction method.

The string split operation assumes the label format will always contain a "/" separator. Consider extracting this to a utility function or using a constant for better maintainability.

-          label: inboxZeroLabels.cold_email.name.split("/")[1],
+          label: inboxZeroLabels.cold_email.name.split("/").pop() || "Cold Email",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 145497b and 10926a4.

📒 Files selected for processing (1)
  • apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx (6 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx (5)
apps/web/hooks/useEmailAccountFull.ts (1)
  • useEmailAccountFull (5-10)
apps/web/app/api/user/rules/route.ts (1)
  • RulesResponse (5-5)
apps/web/utils/label.ts (1)
  • inboxZeroLabels (28-64)
apps/web/utils/types.ts (1)
  • isDefined (8-10)
apps/web/utils/path.ts (1)
  • prefixPath (1-4)
🔇 Additional comments (5)
apps/web/app/(app)/[emailAccountId]/automation/Rules.tsx (5)

16-16: LGTM!

All imports are appropriately added to support the cold email blocker functionality.

Also applies to: 51-61


62-62: LGTM!

Good use of a constant to avoid magic strings.


66-66: LGTM!

Appropriate use of the hook to fetch email account settings.


79-83: LGTM!

Good use of memoization to optimize sorting and prevent unnecessary re-renders.


192-199: LGTM!

The special handling for the cold email blocker rule is well-implemented:

  • Appropriate navigation to dedicated cold email blocker pages
  • Opening in new tabs provides good UX
  • Correctly restricts actions that don't apply to system rules

Also applies to: 207-207, 241-241, 274-277, 285-298, 304-381

@elie222 elie222 merged commit 4de3b80 into main May 25, 2025
7 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Jul 18, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 10, 2025
@elie222 elie222 deleted the feat/cold-email-blocker-as-rule branch December 18, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments