Skip to content

Reorder feature cards on welcome#552

Merged
elie222 merged 6 commits intomainfrom
feat/simplify-assistant
Jul 9, 2025
Merged

Reorder feature cards on welcome#552
elie222 merged 6 commits intomainfrom
feat/simplify-assistant

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Jul 9, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a SettingCard component for consistent settings UI.
    • Added AboutSetting and DigestSetting components for managing personal and digest email settings.
    • Added a demo section showcasing SettingCard variations.
  • Refactor

    • Updated DraftReplies and AboutSectionForm to use SettingCard, improving UI consistency.
    • Modularized AboutSectionForm into separate components for better structure and loading/error handling.
  • Style

    • Adjusted the order and appearance of features on the setup page for improved clarity.
  • Chores

    • Removed unused icon imports from navigation.
    • Updated internal marketing subproject reference.

@vercel
Copy link

vercel bot commented Jul 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero ✅ Ready (Inspect) Visit Preview Jul 9, 2025 7:04pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

New UI components for settings management are introduced, including SettingCard, AboutSetting, and DigestSetting. Existing components such as DraftReplies and AboutSectionForm are refactored to use the new SettingCard and modularized for better data handling and loading states. Some features are temporarily hidden in the settings tab, and the feature order is updated on the setup page.

Changes

File(s) Change Summary
apps/web/components/SettingCard.tsx Added new exported SettingCard component for unified settings UI.
apps/web/app/(app)/[emailAccountId]/assistant/AboutSetting.tsx Added new AboutSetting component with modal dialog for configuring user info.
apps/web/app/(app)/[emailAccountId]/assistant/DigestSetting.tsx Added new DigestSetting component, conditionally rendered based on feature flag.
apps/web/app/(app)/[emailAccountId]/assistant/DraftReplies.tsx Refactored to use SettingCard for layout; removed direct use of Card and CardContent.
apps/web/app/(app)/[emailAccountId]/assistant/SettingsTab.tsx Commented out AboutSetting and DigestSetting to disable their display in the UI.
apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx Refactored into AboutSectionFull, AboutSection, and local AboutSectionForm; modularized.
apps/web/app/(app)/[emailAccountId]/settings/page.tsx Switched usage from AboutSectionForm to new AboutSectionFull component.
apps/web/app/(app)/[emailAccountId]/setup/page.tsx Swapped order and styling of "AI Assistant" and "Reply Zero" features in the features array.
apps/web/app/(landing)/components/page.tsx Added a demo section for SettingCard with three examples.
apps/web/components/SideNav.tsx Removed unused icon imports; no logic changes.
apps/web/app/(marketing) Updated subproject commit reference; no code or logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SettingsTab
    participant AboutSetting
    participant DigestSetting
    participant DraftReplies
    participant SettingCard
    participant AboutSectionFull

    User->>SettingsTab: Open Settings Tab
    SettingsTab->>DraftReplies: Render DraftReplies (as SettingCard)
    SettingsTab-->>AboutSetting: (Currently commented out)
    SettingsTab-->>DigestSetting: (Currently commented out)

    User->>SettingCard: Interact with "Configure" button
    SettingCard->>AboutSetting: Open modal dialog
    AboutSetting->>AboutSection: Render AboutSection in dialog
    AboutSection->>AboutSectionFull: Load user information, handle loading/error
Loading

Suggested reviewers

  • edulelis

Poem

In the meadow of code, a new card appears,
Settings now sparkle, as the UI cheers!
About and Digest, both waiting their turn,
With modular forms, for which rabbits yearn.
A hop and a skip, the features align,
🥕 Here’s to clean settings—so neat and so fine!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(app)/[emailAccountId]/assistant/DigestSetting.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/app/(app)/[emailAccountId]/assistant/AboutSetting.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

apps/web/app/(app)/[emailAccountId]/assistant/SettingsTab.tsx

Oops! Something went wrong! :(

ESLint: 9.28.0

ESLint couldn't find an eslint.config.(js|mjs|cjs) file.

From ESLint v9.0.0, the default configuration file is now eslint.config.js.
If you are using a .eslintrc.* file, please follow the migration guide
to update your configuration file to the new format:

https://eslint.org/docs/latest/use/configure/migration-guide

If you still have problems after following the migration guide, please stop by
https://eslint.org/chat/help to chat with the team.

  • 6 others

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f52210f and a84a1a6.

📒 Files selected for processing (11)
  • apps/web/app/(app)/[emailAccountId]/assistant/AboutSetting.tsx (1 hunks)
  • apps/web/app/(app)/[emailAccountId]/assistant/DigestSetting.tsx (1 hunks)
  • apps/web/app/(app)/[emailAccountId]/assistant/DraftReplies.tsx (3 hunks)
  • apps/web/app/(app)/[emailAccountId]/assistant/SettingsTab.tsx (1 hunks)
  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx (2 hunks)
  • apps/web/app/(app)/[emailAccountId]/settings/page.tsx (2 hunks)
  • apps/web/app/(app)/[emailAccountId]/setup/page.tsx (2 hunks)
  • apps/web/app/(landing)/components/page.tsx (2 hunks)
  • apps/web/app/(marketing) (1 hunks)
  • apps/web/components/SettingCard.tsx (1 hunks)
  • apps/web/components/SideNav.tsx (0 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@elie222 elie222 merged commit 3116562 into main Jul 9, 2025
5 of 6 checks passed
This was referenced Jul 10, 2025
@coderabbitai coderabbitai bot mentioned this pull request Aug 18, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 6, 2025
@elie222 elie222 deleted the feat/simplify-assistant branch December 18, 2025 23:04
@coderabbitai coderabbitai bot mentioned this pull request Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments