Skip to content

Update copy for About section#1228

Merged
elie222 merged 1 commit intomainfrom
feat/update-about-copy
Jan 7, 2026
Merged

Update copy for About section#1228
elie222 merged 1 commit intomainfrom
feat/update-about-copy

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Jan 7, 2026

Generated description

Below is a concise technical summary of the changes proposed in this PR:

graph LR
SettingsTab_("SettingsTab"):::modified
AboutSetting_("AboutSetting"):::modified
CONFIG_ENV_("CONFIG_ENV"):::modified
AboutSection_("AboutSection"):::modified
EMAIL_ACCOUNT_SERVICE_("EMAIL_ACCOUNT_SERVICE"):::modified
AboutSectionForm_("AboutSectionForm"):::modified
USER_VALIDATION_("USER_VALIDATION"):::modified
SettingsTab_ -- "Displays renamed Personal Instructions card with updated description" --> AboutSetting_
SettingsTab_ -- "Reads NEXT_PUBLIC_DIGEST_ENABLED to conditionally render DigestSetting" --> CONFIG_ENV_
AboutSection_ -- "Continues using useEmailAccountFull to load account data" --> EMAIL_ACCOUNT_SERVICE_
AboutSectionForm_ -- "Saves updated personal instructions (about body) via saveAboutBody" --> USER_VALIDATION_
classDef added stroke:#15AA7A
classDef removed stroke:#CD5270
classDef modified stroke:#EDAC4C
linkStyle default stroke:#CBD5E1,font-size:13px
Loading

Updates the user interface copy and examples for the AI's personal instruction section, renaming the 'About you' section to 'Personal Instructions'. Reorders the display of various setting components within the SettingsTab for improved organization.

TopicDetails
Update 'About' Copy Updates the user-facing text and placeholder examples for the 'About you' section, renaming it to 'Personal Instructions' to better reflect its purpose of guiding AI email processing.
Modified files (2)
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
Latest Contributors(1)
UserCommitDate
elie222fix-dialogDecember 31, 2025
Reorder Settings Reorders the display of various setting components within the SettingsTab to improve layout or logical grouping.
Modified files (1)
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
Latest Contributors(1)
UserCommitDate
elie222enable-meeting-briefs-...December 16, 2025
This pull request is reviewed by Baz. Review like a pro on (Baz).

Summary by CodeRabbit

  • Style

    • Renamed "About you" to "Personal Instructions" with updated guidance text
    • Refined placeholder text in settings forms
  • Refactor

    • Reorganized assistant settings components for improved navigation flow
    • Removed duplicate settings renderings
    • Streamlined settings page layout

✏️ Tip: You can customize this high-level summary in your review settings.

@vercel
Copy link

vercel bot commented Jan 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
inbox-zero Ready Ready Preview Jan 7, 2026 1:38pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 7, 2026

📝 Walkthrough

Walkthrough

This PR updates the assistant settings UI terminology from "About you" to "Personal Instructions," reorders settings components in SettingsTab to eliminate duplication, and removes the exported AboutSectionFull() component wrapper from AboutSectionForm while updating placeholder text.

Changes

Cohort / File(s) Summary
UI Terminology Update
apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
Updates UI copy strings from "About you" to "Personal Instructions" in SettingCard title and DialogTitle; updates descriptive text to "Tell the AI about yourself and how you'd like it to handle your emails."
Component Reordering & Deduplication
apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
Reorders AboutSetting (moved after DraftReplies) and PersonalSignatureSetting (moved after WritingStyleSetting); removes duplicate later renderings of these components. Render order and behavior otherwise unchanged.
Component Removal & Placeholder Updates
apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
Removes exported AboutSectionFull() component (previously provided multi-pane layout wrapper); updates placeholder text for about input with new example and CC-related note.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • Move about to the rules page #553: Modifies the same settings UI components (AboutSetting, SettingsTab), reordering and restructuring About/Personal-Instructions rendering.
  • Seperate settings tab #564: Modifies SettingsTab rendering and AboutSetting usage with similar component reordering and simplification patterns.
  • Reorder feature cards on welcome #552: Alters the same component files (AboutSetting.tsx, SettingsTab.tsx, AboutSectionForm.tsx) with changes to About/Personal Instructions UI structure.

Suggested reviewers

  • edulelis

Poem

🐰 From "About You" springs a new name so grand,
"Personal Instructions"—the AI's demand!
Settings reordered, duplicates shed,
A cleaner arrangement, precisely spread. 🎨✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Update copy for About section' accurately reflects the primary changes in the pull request, which involve updating UI text and labels across the About section components.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f11a425 and 037a794.

📒 Files selected for processing (3)
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
🧰 Additional context used
📓 Path-based instructions (16)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/data-fetching.mdc)

**/*.{ts,tsx}: For API GET requests to server, use the swr package
Use result?.serverError with toastError from @/components/Toast for error handling in async operations

**/*.{ts,tsx}: Use wrapper functions for Gmail message operations (get, list, batch, etc.) from @/utils/gmail/message.ts instead of direct API calls
Use wrapper functions for Gmail thread operations from @/utils/gmail/thread.ts instead of direct API calls
Use wrapper functions for Gmail label operations from @/utils/gmail/label.ts instead of direct API calls

**/*.{ts,tsx}: For early access feature flags, create hooks using the naming convention use[FeatureName]Enabled that return a boolean from useFeatureFlagEnabled("flag-key")
For A/B test variant flags, create hooks using the naming convention use[FeatureName]Variant that define variant types, use useFeatureFlagVariantKey() with type casting, and provide a default "control" fallback
Use kebab-case for PostHog feature flag keys (e.g., inbox-cleaner, pricing-options-2)
Always define types for A/B test variant flags (e.g., type PricingVariant = "control" | "variant-a" | "variant-b") and provide type safety through type casting

**/*.{ts,tsx}: Don't use primitive type aliases or misleading types
Don't use empty type parameters in type aliases and interfaces
Don't use this and super in static contexts
Don't use any or unknown as type constraints
Don't use the TypeScript directive @ts-ignore
Don't use TypeScript enums
Don't export imported variables
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions
Don't use TypeScript namespaces
Don't use non-null assertions with the ! postfix operator
Don't use parameter properties in class constructors
Don't use user-defined types
Use as const instead of literal types and type annotations
Use either T[] or Array<T> consistently
Initialize each enum member value explicitly
Use export type for types
Use `impo...

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*Form.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*Form.{ts,tsx}: Use React Hook Form with Zod for validation in form components
Validate form inputs before submission
Show validation errors inline next to form fields

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
apps/web/app/(app)/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)

apps/web/app/(app)/**/*.{ts,tsx}: Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder
If we're in a deeply nested component we will use swr to fetch via API
If you need to use onClick in a component, that component is a client component and file must start with use client

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.cursor/rules/prisma-enum-imports.mdc)

Always import Prisma enums from @/generated/prisma/enums instead of @/generated/prisma/client to avoid Next.js bundling errors in client components

Import Prisma using the project's centralized utility: import prisma from '@/utils/prisma'

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Import specific lodash functions rather than entire lodash library to minimize bundle size (e.g., import groupBy from 'lodash/groupBy')

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Do not export types/interfaces that are only used within the same file. Export later if needed

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{tsx,ts}

📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)

**/*.{tsx,ts}: Use Shadcn UI and Tailwind for components and styling
Use next/image package for images
For API GET requests to server, use the swr package with hooks like useSWR to fetch data
For text inputs, use the Input component with registerProps for form integration and error handling

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{tsx,ts,css}

📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)

Implement responsive design with Tailwind CSS using a mobile-first approach

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/ui-components.mdc)

**/*.tsx: Use the LoadingContent component to handle loading states instead of manual loading state management
For text areas, use the Input component with type='text', autosizeTextarea prop set to true, and registerProps for form integration

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use accessKey attribute on any HTML element
Don't set aria-hidden="true" on focusable elements
Don't add ARIA roles, states, and properties to elements that don't support them
Don't use distracting elements like <marquee> or <blink>
Only use the scope prop on <th> elements
Don't assign non-interactive ARIA roles to interactive HTML elements
Make sure label elements have text content and are associated with an input
Don't assign interactive ARIA roles to non-interactive HTML elements
Don't assign tabIndex to non-interactive HTML elements
Don't use positive integers for tabIndex property
Don't include "image", "picture", or "photo" in img alt prop
Don't use explicit role property that's the same as the implicit/default role
Make static elements with click handlers use a valid role attribute
Always include a title element for SVG elements
Give all elements requiring alt text meaningful information for screen readers
Make sure anchors have content that's accessible to screen readers
Assign tabIndex to non-interactive HTML elements with aria-activedescendant
Include all required ARIA attributes for elements with ARIA roles
Make sure ARIA properties are valid for the element's supported roles
Always include a type attribute for button elements
Make elements with interactive roles and handlers focusable
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden)
Always include a lang attribute on the html element
Always include a title attribute for iframe elements
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress
Accompany onMouseOver/onMouseOut with onFocus/onBlur
Include caption tracks for audio and video elements
Use semantic elements instead of role attributes in JSX
Make sure all anchors are valid and navigable
Ensure all ARIA properties (aria-*) are valid
Use valid, non-abstract ARIA roles for elements with ARIA roles
Use valid AR...

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{jsx,tsx}: Don't use unnecessary fragments
Don't pass children as props
Don't use the return value of React.render
Make sure all dependencies are correctly specified in React hooks
Make sure all React hooks are called from the top level of component functions
Don't forget key props in iterators and collection literals
Don't define React components inside other components
Don't use event handlers on non-interactive elements
Don't assign to React component props
Don't use both children and dangerouslySetInnerHTML props on the same element
Don't use dangerous JSX props
Don't use Array index in keys
Don't insert comments as text nodes
Don't assign JSX properties multiple times
Don't add extra closing tags for components without children
Use <>...</> instead of <Fragment>...</Fragment>
Watch out for possible "wrong" semicolons inside JSX elements
Make sure void (self-closing) elements don't have children
Don't use target="_blank" without rel="noopener"
Don't use <img> elements in Next.js projects
Don't use <head> elements in Next.js projects

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
!(pages/_document).{jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

Don't use the next/head module in pages/_document.js on Next.js projects

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
**/*.{js,ts,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/utilities.mdc)

**/*.{js,ts,jsx,tsx}: Use lodash utilities for common operations (arrays, objects, strings)
Import specific lodash functions to minimize bundle size (e.g., import groupBy from 'lodash/groupBy')

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
apps/web/**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx,js,jsx}: Use @/ path aliases for imports from project root
Prefer self-documenting code over comments; use descriptive variable and function names instead of explaining intent with comments
Add helper functions to the bottom of files, not the top
All imports go at the top of files, no mid-file dynamic imports

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
apps/web/app/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

Follow NextJS app router structure with (app) directory

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
apps/web/**/*.{tsx,jsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{tsx,jsx}: Follow tailwindcss patterns with prettier-plugin-tailwindcss for class sorting
Prefer functional components with hooks in React
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach in components
Follow consistent naming conventions using PascalCase for components
Use LoadingContent component for async data with loading and error states
Use React Hook Form with Zod validation for form handling
Use result?.serverError with toastError and toastSuccess for error handling in forms

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
apps/web/**/*.{ts,tsx,js,jsx,json,css}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

Format code with Prettier

Files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx
  • apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx
🧠 Learnings (4)
📚 Learning: 2025-07-08T13:14:07.449Z
Learnt from: elie222
Repo: elie222/inbox-zero PR: 537
File: apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx:30-34
Timestamp: 2025-07-08T13:14:07.449Z
Learning: The clean onboarding page in apps/web/app/(app)/[emailAccountId]/clean/onboarding/page.tsx is intentionally Gmail-specific and should show an error for non-Google email accounts rather than attempting to support multiple providers.

Applied to files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
📚 Learning: 2025-11-25T14:40:13.649Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/ui-components.mdc:0-0
Timestamp: 2025-11-25T14:40:13.649Z
Learning: Applies to **/*.{tsx,ts,jsx,js} : For text inputs in forms, use the `Input` component with `type='email'`, `name`, `label`, `registerProps` from react-hook-form, and `error` props

Applied to files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
📚 Learning: 2025-11-25T14:40:15.063Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/ui-components.mdc:0-0
Timestamp: 2025-11-25T14:40:15.063Z
Learning: Applies to **/*.{tsx,ts} : For text inputs, use the `Input` component with `registerProps` for form integration and error handling

Applied to files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
📚 Learning: 2025-11-25T14:40:13.649Z
Learnt from: CR
Repo: elie222/inbox-zero PR: 0
File: .cursor/rules/ui-components.mdc:0-0
Timestamp: 2025-11-25T14:40:13.649Z
Learning: Applies to **/*.{tsx,ts,jsx,js} : For text areas in forms, use the `Input` component with `type='text'`, `autosizeTextarea` prop, `rows`, `name`, `placeholder`, `registerProps` from react-hook-form, and `error` props

Applied to files:

  • apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx
🧬 Code graph analysis (1)
apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx (3)
apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx (1)
  • AboutSetting (16-45)
apps/web/app/(app)/[emailAccountId]/assistant/settings/WritingStyleSetting.tsx (1)
  • WritingStyleSetting (29-53)
apps/web/app/(app)/[emailAccountId]/assistant/settings/PersonalSignatureSetting.tsx (1)
  • PersonalSignatureSetting (33-57)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Baz Reviewer
  • GitHub Check: cubic · AI code reviewer
  • GitHub Check: test
🔇 Additional comments (4)
apps/web/app/(app)/[emailAccountId]/assistant/settings/SettingsTab.tsx (1)

16-18: LGTM! Component organization improved.

The reordering of AboutSetting and PersonalSignatureSetting to earlier positions and removal of duplicate renderings improves the component structure without affecting functionality.

apps/web/app/(app)/[emailAccountId]/assistant/settings/AboutSetting.tsx (1)

21-22: LGTM! Clear and consistent copy improvements.

The terminology change from "About you" to "Personal Instructions" is more descriptive and professional. The updated description clearly explains the feature's purpose for AI email handling.

Also applies to: 32-35

apps/web/app/(app)/[emailAccountId]/settings/AboutSectionForm.tsx (2)

94-97: LGTM! Improved placeholder examples.

The updated placeholder text provides clearer, more actionable examples for users, including specific scenarios like CC handling and email classification.


24-40: No action needed. There is no AboutSectionFull() export in this file. The codebase search found zero references to AboutSectionFull anywhere. The file currently exports only AboutSection, and AboutSectionForm remains an internal component. The concern about a breaking API change does not apply.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@elie222 elie222 merged commit e7990f6 into main Jan 7, 2026
15 checks passed
@elie222 elie222 deleted the feat/update-about-copy branch January 7, 2026 13:47
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments