Skip to content

Comments

Release calendar feature#835

Merged
elie222 merged 2 commits intomainfrom
feat/calendar-release
Oct 6, 2025
Merged

Release calendar feature#835
elie222 merged 2 commits intomainfrom
feat/calendar-release

Conversation

@elie222
Copy link
Owner

@elie222 elie222 commented Oct 6, 2025

Summary by CodeRabbit

  • New Features

    • Added a “Calendars” item in the sidebar navigation.
    • Introduced a “Connect your calendar” step in setup, marked complete when a calendar is connected.
  • UI/UX

    • Revamped calendar connection card: static Google Calendar title and icon, clearer disconnected state, simplified guidance; removed provider badge and counts.
    • Improved Calendars page header with description and spacing.
  • API

    • Setup progress now reports calendar connection status to power the new checklist step.
  • Chores

    • Bumped version to v2.15.0.

@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
inbox-zero Ready Ready Preview Oct 6, 2025 9:36am

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 6, 2025

Walkthrough

Adds calendars navigation and UI updates, introduces a setup step reflecting calendar connection status, and updates the setup-progress API to expose calendarConnected. Adjusts CalendarConnectionCard presentation, replaces a page heading component, and bumps version to v2.15.0.

Changes

Cohort / File(s) Summary
Calendar connection card UI
apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
Replaces icon with Google Calendar SVG via next/image; static "Google Calendar" title; removes provider badge and calendars summary; shows email and a red "Disconnected" only when not connected; updates description text; keeps disconnect and toggle behavior.
Calendars page header
apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
Switches to PageHeader with description; updates imports; adjusts spacing (gap, mt-6).
Setup flow: calendar step
apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
Adds calendar step with CalendarIcon; threads isCalendarConnected through props to mark completion; updates interfaces and rendering.
Setup progress API
apps/web/app/api/user/setup-progress/route.ts
Queries emailAccount.calendarConnections (id only, take: 1); derives steps.calendarConnected from presence; includes it in response.
Side navigation: Calendars item
apps/web/components/SideNav.tsx
Imports CalendarIcon; adds "Calendars" nav item pointing to current account’s /calendars path; follows existing filtering.
Version bump
version.txt
Updates version from v2.14.2 to v2.15.0.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant U as User
  participant SN as SideNav
  participant SP as Setup Page
  participant API as setup-progress API
  participant DB as Database
  participant CAL as Calendars UI

  U->>SP: Open setup
  SP->>API: GET /api/user/setup-progress
  API->>DB: Query emailAccount with calendarConnections (id, take:1)
  DB-->>API: emailAccount + calendarConnections
  API-->>SP: steps { ..., calendarConnected }
  SP-->>U: Render checklist incl. Calendar step (complete if connected)

  Note over U,SN: User navigates to Calendars
  U->>SN: Click "Calendars"
  SN-->>CAL: Route to /[emailAccountId]/calendars
  CAL-->>U: Show "Google Calendar" card, email, status, toggles
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

Poem

A hop, a skip, a calendar tick—
I nudge the setup, quick-quick-quick.
A shiny tab for dates to see,
Connected? I twitch with glee.
If not, I’ll boop “Disconnected” red—
Then bound to toggles, whiskers spread.
v2.15.0—carrots ahead! 🥕✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title “Release calendar feature” directly reflects the main objective of the changeset by succinctly indicating that the new calendar integration is being shipped, making it clear and specific enough for teammates to understand the purpose at a glance.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/calendar-release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx (1)

105-111: Consider the unoptimized prop necessity.

The unoptimized prop on the Image component for an SVG may not be necessary, as SVGs are typically better served directly without Next.js image optimization. However, this is acceptable if you prefer explicit control.

Consider removing the unoptimized prop:

 <Image
   src="/images/product/google-calendar.svg"
   alt="Google Calendar"
   width={32}
   height={32}
-  unoptimized
 />
📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1482acc and a49f867.

⛔ Files ignored due to path filters (1)
  • apps/web/public/images/product/google-calendar.svg is excluded by !**/*.svg
📒 Files selected for processing (6)
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx (4 hunks)
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx (1 hunks)
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx (8 hunks)
  • apps/web/app/api/user/setup-progress/route.ts (2 hunks)
  • apps/web/components/SideNav.tsx (2 hunks)
  • version.txt (1 hunks)
🧰 Additional context used
📓 Path-based instructions (19)
apps/web/**/*.{ts,tsx}

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.{ts,tsx}: Use TypeScript with strict null checks
Path aliases: Use @/ for imports from project root
Use proper error handling with try/catch blocks
Format code with Prettier
Leverage TypeScript inference for better DX

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/**

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

NextJS app router structure with (app) directory

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/api/**/route.ts

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/app/api/**/route.ts: Use withAuth for user-level operations
Use withEmailAccount for email-account-level operations
Do NOT use POST API routes for mutations - use server actions instead
No need for try/catch in GET routes when using middleware
Export response types from GET routes

apps/web/app/api/**/route.ts: Wrap all GET API route handlers with withAuth or withEmailAccount middleware for authentication and authorization.
Export response types from GET API routes for type-safe client usage.
Do not use try/catch in GET API routes when using authentication middleware; rely on centralized error handling.

Files:

  • apps/web/app/api/user/setup-progress/route.ts
!{.cursor/rules/*.mdc}

📄 CodeRabbit inference engine (.cursor/rules/cursor-rules.mdc)

Never place rule files in the project root, in subdirectories outside .cursor/rules, or in any other location

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • version.txt
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
**/*.ts

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.ts: The same validation should be done in the server action too
Define validation schemas using Zod

Files:

  • apps/web/app/api/user/setup-progress/route.ts
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/logging.mdc)

**/*.{ts,tsx}: Use createScopedLogger for logging in backend TypeScript files
Typically add the logger initialization at the top of the file when using createScopedLogger
Only use .with() on a logger instance within a specific function, not for a global logger

Import Prisma in the project using import prisma from "@/utils/prisma";

**/*.{ts,tsx}: Don't use TypeScript enums.
Don't use TypeScript const enum.
Don't use the TypeScript directive @ts-ignore.
Don't use primitive type aliases or misleading types.
Don't use empty type parameters in type aliases and interfaces.
Don't use any or unknown as type constraints.
Don't use implicit any type on variable declarations.
Don't let variables evolve into any type through reassignments.
Don't use non-null assertions with the ! postfix operator.
Don't misuse the non-null assertion operator (!) in TypeScript files.
Don't use user-defined types.
Use as const instead of literal types and type annotations.
Use export type for types.
Use import type for types.
Don't declare empty interfaces.
Don't merge interfaces and classes unsafely.
Don't use overload signatures that aren't next to each other.
Use the namespace keyword instead of the module keyword to declare TypeScript namespaces.
Don't use TypeScript namespaces.
Don't export imported variables.
Don't add type annotations to variables, parameters, and class properties that are initialized with literal expressions.
Don't use parameter properties in class constructors.
Use either T[] or Array consistently.
Initialize each enum member value explicitly.
Make sure all enum members are literal values.

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
**/api/**/route.ts

📄 CodeRabbit inference engine (.cursor/rules/security.mdc)

**/api/**/route.ts: ALL API routes that handle user data MUST use appropriate authentication and authorization middleware (withAuth or withEmailAccount).
ALL database queries in API routes MUST be scoped to the authenticated user/account (e.g., include userId or emailAccountId in query filters).
Always validate that resources belong to the authenticated user before performing operations (resource ownership validation).
Use withEmailAccount middleware for API routes that operate on a specific email account (i.e., use or require emailAccountId).
Use withAuth middleware for API routes that operate at the user level (i.e., use or require only userId).
Use withError middleware (with proper validation) for public endpoints, custom authentication, or cron endpoints.
Cron endpoints MUST use withError middleware and validate the cron secret using hasCronSecret(request) or hasPostCronSecret(request).
Cron endpoints MUST capture unauthorized attempts with captureException and return a 401 status for unauthorized requests.
All parameters in API routes MUST be validated for type, format, and length before use.
Request bodies in API routes MUST be validated using Zod schemas before use.
All Prisma queries in API routes MUST only return necessary fields and never expose sensitive data.
Error messages in API routes MUST not leak internal information or sensitive data; use generic error messages and SafeError where appropriate.
API routes MUST use a consistent error response format, returning JSON with an error message and status code.
All findUnique and findFirst Prisma calls in API routes MUST include ownership filters (e.g., userId or emailAccountId).
All findMany Prisma calls in API routes MUST be scoped to the authenticated user's data.
Never use direct object references in API routes without ownership checks (prevent IDOR vulnerabilities).
Prevent mass assignment vulnerabilities by only allowing explicitly whitelisted fields in update operations in AP...

Files:

  • apps/web/app/api/user/setup-progress/route.ts
apps/web/app/api/**/*.{ts,js}

📄 CodeRabbit inference engine (.cursor/rules/security-audit.mdc)

apps/web/app/api/**/*.{ts,js}: All API route handlers in 'apps/web/app/api/' must use authentication middleware: withAuth, withEmailAccount, or withError (with custom authentication logic).
All Prisma queries in API routes must include user/account filtering (e.g., emailAccountId or userId in WHERE clauses) to prevent unauthorized data access.
All parameters used in API routes must be validated before use; do not use parameters from 'params' or request bodies directly in queries without validation.
Request bodies in API routes should use Zod schemas for validation.
API routes should only return necessary fields using Prisma's 'select' and must not include sensitive data in error messages.
Error messages in API routes must not reveal internal details; use generic errors and SafeError for user-facing errors.
All QStash endpoints (API routes called via publishToQstash or publishToQstashQueue) must use verifySignatureAppRouter to verify request authenticity.
All cron endpoints in API routes must use hasCronSecret or hasPostCronSecret for authentication.
Do not hardcode weak or plaintext secrets in API route files; secrets must not be directly assigned as string literals.
Review all new withError usage in API routes to ensure custom authentication is implemented where required.

Files:

  • apps/web/app/api/user/setup-progress/route.ts
**/*.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{js,jsx,ts,tsx}: Don't use elements in Next.js projects.
Don't use elements in Next.js projects.
Don't use namespace imports.
Don't access namespace imports dynamically.
Don't use global eval().
Don't use console.
Don't use debugger.
Don't use var.
Don't use with statements in non-strict contexts.
Don't use the arguments object.
Don't use consecutive spaces in regular expression literals.
Don't use the comma operator.
Don't use unnecessary boolean casts.
Don't use unnecessary callbacks with flatMap.
Use for...of statements instead of Array.forEach.
Don't create classes that only have static members (like a static namespace).
Don't use this and super in static contexts.
Don't use unnecessary catch clauses.
Don't use unnecessary constructors.
Don't use unnecessary continue statements.
Don't export empty modules that don't change anything.
Don't use unnecessary escape sequences in regular expression literals.
Don't use unnecessary labels.
Don't use unnecessary nested block statements.
Don't rename imports, exports, and destructured assignments to the same name.
Don't use unnecessary string or template literal concatenation.
Don't use String.raw in template literals when there are no escape sequences.
Don't use useless case statements in switch statements.
Don't use ternary operators when simpler alternatives exist.
Don't use useless this aliasing.
Don't initialize variables to undefined.
Don't use the void operators (they're not familiar).
Use arrow functions instead of function expressions.
Use Date.now() to get milliseconds since the Unix Epoch.
Use .flatMap() instead of map().flat() when possible.
Use literal property access instead of computed property access.
Don't use parseInt() or Number.parseInt() when binary, octal, or hexadecimal literals work.
Use concise optional chaining instead of chained logical expressions.
Use regular expression literals instead of the RegExp constructor when possible.
Don't use number literal object member names th...

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
!pages/_document.{js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

!pages/_document.{js,jsx,ts,tsx}: Don't import next/document outside of pages/_document.jsx in Next.js projects.
Don't import next/document outside of pages/_document.jsx in Next.js projects.

Files:

  • apps/web/app/api/user/setup-progress/route.ts
  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • version.txt
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/**/*.tsx

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

apps/web/**/*.tsx: Follow tailwindcss patterns with prettier-plugin-tailwindcss
Prefer functional components with hooks
Use shadcn/ui components when available
Ensure responsive design with mobile-first approach
Follow consistent naming conventions (PascalCase for components)
Use LoadingContent component for async data
Use result?.serverError with toastError and toastSuccess
Use LoadingContent component to handle loading and error states consistently
Pass loading, error, and children props to LoadingContent

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/form-handling.mdc)

**/*.tsx: Use React Hook Form with Zod for validation
Validate form inputs before submission
Show validation errors inline next to form fields

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/(app)/*/**

📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)

Components for the page are either put in page.tsx, or in the apps/web/app/(app)/PAGE_NAME folder

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/(app)/*/**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)

If you need to use onClick in a component, that component is a client component and file must start with 'use client'

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/(app)/*/**/**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/page-structure.mdc)

If we're in a deeply nested component we will use swr to fetch via API

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/app/**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/project-structure.mdc)

Components with onClick must be client components with use client directive

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
**/*.{jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{jsx,tsx}: Don't destructure props inside JSX components in Solid projects.
Don't use both children and dangerouslySetInnerHTML props on the same element.
Don't use Array index in keys.
Don't assign to React component props.
Don't define React components inside other components.
Don't use event handlers on non-interactive elements.
Don't assign JSX properties multiple times.
Don't add extra closing tags for components without children.
Use <>...</> instead of ....
Don't insert comments as text nodes.
Don't use the return value of React.render.
Make sure all dependencies are correctly specified in React hooks.
Make sure all React hooks are called from the top level of component functions.
Don't use unnecessary fragments.
Don't pass children as props.
Use semantic elements instead of role attributes in JSX.

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
**/*.{html,jsx,tsx}

📄 CodeRabbit inference engine (.cursor/rules/ultracite.mdc)

**/*.{html,jsx,tsx}: Don't use or elements.
Don't use accessKey attribute on any HTML element.
Don't set aria-hidden="true" on focusable elements.
Don't add ARIA roles, states, and properties to elements that don't support them.
Only use the scope prop on elements.
Don't assign non-interactive ARIA roles to interactive HTML elements.
Make sure label elements have text content and are associated with an input.
Don't assign interactive ARIA roles to non-interactive HTML elements.
Don't assign tabIndex to non-interactive HTML elements.
Don't use positive integers for tabIndex property.
Don't include "image", "picture", or "photo" in img alt prop.
Don't use explicit role property that's the same as the implicit/default role.
Make static elements with click handlers use a valid role attribute.
Always include a title element for SVG elements.
Give all elements requiring alt text meaningful information for screen readers.
Make sure anchors have content that's accessible to screen readers.
Assign tabIndex to non-interactive HTML elements with aria-activedescendant.
Include all required ARIA attributes for elements with ARIA roles.
Make sure ARIA properties are valid for the element's supported roles.
Always include a type attribute for button elements.
Make elements with interactive roles and handlers focusable.
Give heading elements content that's accessible to screen readers (not hidden with aria-hidden).
Always include a lang attribute on the html element.
Always include a title attribute for iframe elements.
Accompany onClick with at least one of: onKeyUp, onKeyDown, or onKeyPress.
Accompany onMouseOver/onMouseOut with onFocus/onBlur.
Include caption tracks for audio and video elements.
Make sure all anchors are valid and navigable.
Ensure all ARIA properties (aria-*) are valid.
Use valid, non-abstract ARIA roles for elements with ARIA roles.
Use valid ARIA state and property values.
Use valid values for the autocomplete attribute on input eleme...

Files:

  • apps/web/app/(app)/[emailAccountId]/calendars/page.tsx
  • apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx
  • apps/web/components/SideNav.tsx
  • apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
apps/web/components/**/*.tsx

📄 CodeRabbit inference engine (apps/web/CLAUDE.md)

Use React Hook Form with Zod validation for form handling

Use the LoadingContent component to handle loading and error states consistently in data-fetching components.

Use PascalCase for components (e.g. components/Button.tsx)

Files:

  • apps/web/components/SideNav.tsx
🧬 Code graph analysis (2)
apps/web/app/(app)/[emailAccountId]/calendars/page.tsx (2)
apps/web/components/PageWrapper.tsx (1)
  • PageWrapper (3-20)
apps/web/components/PageHeader.tsx (1)
  • PageHeader (14-34)
apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx (2)
apps/web/components/ui/card.tsx (2)
  • CardTitle (141-141)
  • CardDescription (142-142)
apps/web/components/Typography.tsx (1)
  • TypographyP (129-129)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: cubic · AI code reviewer
🔇 Additional comments (11)
version.txt (1)

1-1: LGTM!

The version bump to v2.15.0 is appropriate for this calendar feature release.

apps/web/app/(app)/[emailAccountId]/calendars/page.tsx (2)

2-2: LGTM!

The migration from PageHeading to PageHeader with a descriptive text improves the user experience by clearly explaining the calendar feature's purpose.

Also applies to: 9-15


16-16: LGTM!

The increased spacing (mt-6) provides better visual separation between the header and content.

apps/web/app/api/user/setup-progress/route.ts (1)

31-31: LGTM!

The calendar connection check follows the same pattern as other setup steps, only selects necessary fields (id with take: 1), and properly derives the calendarConnected flag. The implementation is secure and follows the coding guidelines for API routes.

Also applies to: 47-47

apps/web/components/SideNav.tsx (2)

14-14: LGTM!

The CalendarIcon import from lucide-react is consistent with other icon imports in the component.


105-109: LGTM!

The new "Calendars" navigation item follows the same pattern as existing items and properly uses prefixPath for route construction.

apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx (2)

115-121: LGTM!

The conditional "Disconnected" indicator provides clear visual feedback when the calendar connection is inactive. The email display is helpful for identifying which account is connected.


141-144: LGTM!

The descriptive text using TypographyP clearly explains the calendar toggle functionality to users.

apps/web/app/(app)/[emailAccountId]/setup/SetupContent.tsx (3)

12-12: LGTM!

The CalendarIcon import is consistent with other icon imports used for setup steps.


215-215: LGTM!

The isCalendarConnected prop is properly threaded through the component hierarchy (SetupContentSetupPageContentChecklist), following the same pattern as other setup step flags.

Also applies to: 225-225, 331-331, 347-347, 357-357, 384-384


288-297: LGTM!

The new calendar connection step follows the same pattern as existing setup steps, with appropriate icon, color scheme (yellow), time estimate, and action text. The implementation is consistent and well-integrated into the setup flow.

/>
<div>
<CardTitle className="text-lg">{connection.email}</CardTitle>
<CardTitle className="text-lg">Google Calendar</CardTitle>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

Verify future provider support.

The title is hardcoded to "Google Calendar". If the application plans to support other calendar providers (Outlook, Apple Calendar, etc.) in the future, this will need to become dynamic based on the connection's provider.

Run the following script to check if there are multiple calendar providers in the codebase:


🏁 Script executed:

#!/bin/bash
# Description: Search for calendar provider types or enums to determine if multiple providers are planned

# Search for calendar provider types
echo "=== Searching for calendar provider types ==="
rg -nP --type=ts 'CalendarProvider|calendar.*provider|provider.*calendar' -A 3 -B 3

# Search for calendar connection provider field
echo -e "\n=== Searching for provider field in calendar schema ==="
rg -nP 'calendarConnection|CalendarConnection' -A 10 | rg -P 'provider'

# Check for Outlook/Microsoft calendar references
echo -e "\n=== Checking for non-Google calendar references ==="
rg -nP --type=ts 'outlook|microsoft.*calendar|apple.*calendar' -i

Length of output: 36031


🏁 Script executed:

#!/bin/bash
# Display context around CalendarConnectionCard.tsx line 113
FILE=$(fd -p 'CalendarConnectionCard.tsx' -t f | head -n 1)
echo "File: $FILE"
sed -n '90,140p' "$FILE"

Length of output: 1612


Make calendar provider title and icon dynamic
Update CalendarConnectionCard.tsx to use connection.provider (e.g. “google” | “microsoft”) to select the icon and title instead of hardcoding “Google Calendar.”
File: apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx (around line 113)

🤖 Prompt for AI Agents
In apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx
around line 113, the card title and icon are hardcoded to "Google Calendar";
change them to derive from connection.provider (e.g. "google" or "microsoft").
Implement a small mapping or switch that returns the proper display title
("Google Calendar", "Microsoft Calendar" etc.) and corresponding icon component
based on connection.provider, then render the mapped icon and title in place of
the hardcoded values; ensure you fall back to a sensible default for unknown
providers.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 7 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx">

<violation number="1" location="apps/web/app/(app)/[emailAccountId]/calendars/CalendarConnectionCard.tsx:113">
Hardcoding the title to &quot;Google Calendar&quot; mislabels non-Google connections. The calendars API returns each connection&#39;s provider (including Microsoft), so Outlook connections will appear as Google here. Please derive the label/icon from `connection.provider` instead of fixing it to Google.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@elie222 elie222 merged commit 2770034 into main Oct 6, 2025
19 checks passed
@elie222 elie222 deleted the feat/calendar-release branch December 18, 2025 23:01
@coderabbitai coderabbitai bot mentioned this pull request Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant