Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation warnings: The type attribute is unnecessary for JavaScript resources #184

Closed
tomas-eklund opened this issue Jan 6, 2022 · 0 comments
Closed

Validation warnings: The type attribute is unnecessary for JavaScript resources #184

tomas-eklund opened this issue Jan 6, 2022 · 0 comments

Comments

@tomas-eklund
Copy link

Pages created with Hello Elementor and Elementor Pro does not fully validate with the w3.org Markup Validation Service. Or at least it will result in a ton of warnings like:

The type attribute is unnecessary for JavaScript resources.

According to this Stack Overflow answer this can be resolved by adding HTML5 support to script and style, like so:

add_theme_support( 'html5', array( 'script', 'style' ) );

Is there a reason this is not already built-in behavior of the Hello Elementor theme?

Would you consider adding it?
arielk added a commit to arielk/hello-theme that referenced this issue Jul 1, 2022
@arielk
Tweak: Add theme_support for script and style to avoid validation…
dfefd21 
… warnings (elementor#184)
KingYes added a commit that referenced this issue Jul 3, 2022
@arielk @romanbondar @KingYes
Tweak: Align page title width to be like the header and footer (#188)
081a12d 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
@arielk arielk closed this as completed Jul 3, 2022
KingYes added a commit that referenced this issue Jul 6, 2022
@arielk @romanbondar @KingYes
Tweak: Added Skip to Content link to dynamic or template header (#209)
e46ce95 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Jul 6, 2022
@arielk @romanbondar @KingYes
Changelog (#210)
aaa006a 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Jul 10, 2022
@arielk @romanbondar @KingYes
Changelog (#211)
dc26f05 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Jul 11, 2022
@arielk @romanbondar @KingYes
Internal: New screenshot (#212)
f97ba30 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Jul 11, 2022
@arielk @romanbondar @KingYes
Fixes (#215)
c4dc04c 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

* Fix table colors

* Changelog

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Sep 7, 2022
@arielk @romanbondar @KingYes
Internal: Change text in custom logo (#226)
ff691c0 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

* Fix table colors

* Changelog

* Change text

* Update customizer-functions.php

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Sep 8, 2022
@arielk @romanbondar @KingYes
Fix: Create logo Style & polish (#227)
c5c8307 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

* Fix table colors

* Changelog

* Change text

* Update customizer-functions.php

* Fix: Create logo Style & polish

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Sep 11, 2022
@arielk @romanbondar @KingYes
Fix: Change description (#228)
74eb6f8 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

* Fix table colors

* Changelog

* Change text

* Update customizer-functions.php

* Fix: Create logo Style & polish

* Change description

* Update includes/customizer-functions.php

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
KingYes added a commit that referenced this issue Mar 19, 2023
@arielk @romanbondar @KingYes
Tweak: Added support for the new Elementor version (#265)
67c198a 
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

* Changelog

* changelog

* changelog

* Update release date

* Update date release

* Internal: New screenshot

* Fix: Tables with various colors looks weird (#126)

* Changelog

* Fix table colors

* Changelog

* Change text

* Update customizer-functions.php

* Fix: Create logo Style & polish

* Change description

* Update includes/customizer-functions.php

* Fix eslint package

* Restore package lock file

* Tweak: Added support for the new Elementor version

---------

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomas-eklund @arielk