Skip to content

Commit 081a12d

Browse files
arielkromanbondarKingYes
authored
Tweak: Align page title width to be like the header and footer (#188)
* few comments * Tested up to 5.6 * remove duplicate * add utilities scss * Post Password Form Submit button alignment When a post is password-protected, the Post Password Form Submit button isn't aligned properly. * Update Changelog * Move Hello Theme Header & Footer experiment to stable status * Changelog * Build * Add ref to changelog * Aligned page title to the header and footer * Internal: Add accessibility-ready tag * Tweak: Remove unused image file * Internal: update text & links * Internal: fix URL * Tweak: Mark the header footer tab in the customizer * Fix: Remove override the default width * Changelog * Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184) * A different way to align title Co-authored-by: Roman <[email protected]> Co-authored-by: Yakir Sitbon <[email protected]>
1 parent 1bac293 commit 081a12d

File tree

10 files changed

+43
-21
lines changed

10 files changed

+43
-21
lines changed

‎README.md

+8-5
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,9 @@
1010
**Requires PHP:** 5.6
1111
**License:** GNU General Public License v3 or later
1212
**License URI:** https://www.gnu.org/licenses/gpl-3.0.html
13-
**Tags:** custom-menu, custom-logo, featured-images, rtl-language-support, threaded-comments, translation-ready
1413

1514
A lightweight, plain-vanilla theme for Elementor page builder.
1615

17-
***Hello Elementor*** is distributed under the terms of the GNU GPL v3 or later.
18-
1916
## Description ##
2017

2118
A basic, plain-vanilla, lightweight theme, best suited for building your site using Elementor page builder.
@@ -95,10 +92,16 @@ Source: https://stocksnap.io/photo/4B83RD7BV9
9592

9693
## Changelog ##
9794

95+
### 2.6.0 - 2022-07-XX ###
96+
* Tweak: Changed the containers to `max-width: 1140px` instead of `960px` to align with the header-footer width
97+
Tweak: Centering the page title for better consistency in some cases
98+
* Tweak: Added link between the customizer to Elementor global settings
99+
* Fix: Post Password Form Submit button alignment (Props [@romanbondar](https://github.com/romanbondar))
100+
98101
### 2.5.0 - 2022-01-26 ###
99102
* Tweak: Added keyboard navigation to Hello theme menus
100-
* Tweak: Added Skip Links for better accessibility
101-
* Tweak: Added underline for text links in Post Content for better accessibility
103+
* Tweak: Added Skip Links and `#content` for the main wrapper for better accessibility ([#133](https://github.com/elementor/hello-theme/issues/133))
104+
* Tweak: Added underline for text links in Post Content for better accessibility
102105
* Tweak: Removed `outline: none` from inputs for better accessibility
103106
* Fix: Footer menu location is not being presented on sites that are not running Elementor
104107

‎assets/images/elementor-logo.png

-23.1 KB
Binary file not shown.

‎assets/scss/customizer.scss

+8
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,14 @@
22
* Style for your Customizer editor.
33
*/
44

5+
#accordion-section-hello_theme_options .accordion-section-title {
6+
color: #c36;
7+
8+
&:after {
9+
color: #c36;
10+
}
11+
}
12+
513
#sub-accordion-section-hello_theme_options.accordion-section-content {
614
background: #fff;
715
}

‎assets/scss/style.scss

+2-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
License: GNU General Public License v3 or later.
1313
License URI: https://www.gnu.org/licenses/gpl-3.0.html
1414
Text Domain: hello-elementor
15-
Tags: flexible-header, custom-colors, custom-menu, custom-logo, featured-images, rtl-language-support, threaded-comments, translation-ready
15+
Description: A lightweight, plain-vanilla, best suited for building your site using Elementor website builder. Visit https://elementor.com/hello-theme/ to learn more.
16+
Tags: accessibility-ready, flexible-header, custom-colors, custom-menu, custom-logo, featured-images, rtl-language-support, threaded-comments, translation-ready,
1617
*/
1718

1819
// Root

‎assets/scss/theme/_general.scss

+10
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,13 @@
9494
.hide {
9595
display: none !important;
9696
}
97+
98+
.post-password-form p {
99+
width: 100%;
100+
display: flex;
101+
align-items: flex-end;
102+
}
103+
104+
.post-password-form [type=submit] {
105+
margin-left: 3px;
106+
}

‎assets/scss/theme/_layout.scss

+1-6
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Basic responsive layout
33
*/
44

5-
$containers: '.site-header .header-inner,.site-header:not(.dynamic-header), .site-footer .footer-inner, .site-footer:not(.dynamic-footer),body:not([class*="elementor-page-"]) .site-main';
5+
$containers: '.site-header .header-inner,.site-header:not(.dynamic-header), .site-footer .footer-inner, .site-footer:not(.dynamic-footer),body:not([class*="elementor-page-"]) .site-main, .page-header .entry-title';
66

77
#{$containers} {
88
margin-right: auto;
@@ -90,11 +90,6 @@ $containers: '.site-header .header-inner,.site-header:not(.dynamic-header), .sit
9090
@media (min-width: $screen-xl) {
9191

9292
#{$containers} {
93-
max-width: 960px;
94-
}
95-
96-
/* Override the default width for the dynamic header and footer */
97-
.site-header .header-inner, .site-footer .footer-inner {
9893
max-width: 1140px;
9994
}
10095

‎functions.php

+2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ function hello_elementor_setup() {
5050
'comment-list',
5151
'gallery',
5252
'caption',
53+
'script',
54+
'style',
5355
]
5456
);
5557
add_theme_support(

‎includes/settings/settings-footer.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -482,12 +482,12 @@ public function get_additional_tab_content() {
482482
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
483483
<p>%2$s</p>
484484
</div>
485-
<a class="elementor-button elementor-button-default elementor-nerd-box-link" target="_blank" href="https://elementor.com/pro/?utm_source=panel-widgets&amp;utm_campaign=gopro&amp;utm_medium=wp-dash&amp;utm_term=helloelementor">%3$s</a>
485+
<a class="elementor-button elementor-button-default elementor-nerd-box-link" target="_blank" href="https://go.elementor.com/hello-theme-footer/">%3$s</a>
486486
</div>
487487
',
488488
__( 'Create a custom footer with multiple options', 'hello-elementor' ),
489489
__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ),
490-
__( 'Go Pro', 'hello-elementor' ),
490+
__( 'Upgrade', 'hello-elementor' ),
491491
get_template_directory_uri() . '/assets/images/go-pro.svg'
492492
);
493493
} else {

‎includes/settings/settings-header.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -501,12 +501,12 @@ public function get_additional_tab_content() {
501501
<p class="elementor-panel-heading-title elementor-nerd-box-title">%1$s</p>
502502
<p>%2$s</p>
503503
</div>
504-
<a class="elementor-button elementor-button-default elementor-nerd-box-link" target="_blank" href="https://elementor.com/pro/?utm_source=panel-widgets&amp;utm_campaign=gopro&amp;utm_medium=wp-dash&amp;utm_term=helloelementor">%3$s</a>
504+
<a class="elementor-button elementor-button-default elementor-nerd-box-link" target="_blank" href="https://go.elementor.com/hello-theme-header/">%3$s</a>
505505
</div>
506506
',
507507
__( 'Create a custom header with multiple options', 'hello-elementor' ),
508508
__( 'Upgrade to Elementor Pro and enjoy free design and many more features', 'hello-elementor' ),
509-
__( 'Go Pro', 'hello-elementor' ),
509+
__( 'Upgrade', 'hello-elementor' ),
510510
get_template_directory_uri() . '/assets/images/go-pro.svg'
511511
);
512512
} else {

‎readme.txt

+8-5
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,9 @@ Version: 2.5.0
88
Requires PHP: 5.6
99
License: GNU General Public License v3 or later
1010
License URI: https://www.gnu.org/licenses/gpl-3.0.html
11-
Tags: custom-menu, custom-logo, featured-images, rtl-language-support, threaded-comments, translation-ready
1211

1312
A lightweight, plain-vanilla theme for Elementor page builder.
1413

15-
***Hello Elementor*** is distributed under the terms of the GNU GPL v3 or later.
16-
1714
== Description ==
1815

1916
A basic, plain-vanilla, lightweight theme, best suited for building your site using Elementor page builder.
@@ -93,10 +90,16 @@ Source: https://stocksnap.io/photo/4B83RD7BV9
9390

9491
== Changelog ==
9592

93+
= 2.6.0 - 2022-07-XX =
94+
* Tweak: Changed the containers to `max-width: 1140px` instead of `960px` to align with the header-footer width
95+
Tweak: Centering the page title for better consistency in some cases
96+
* Tweak: Added link between the customizer to Elementor global settings
97+
* Fix: Post Password Form Submit button alignment (Props [@romanbondar](https://github.com/romanbondar))
98+
9699
= 2.5.0 - 2022-01-26 =
97100
* Tweak: Added keyboard navigation to Hello theme menus
98-
* Tweak: Added Skip Links for better accessibility
99-
* Tweak: Added underline for text links in Post Content for better accessibility
101+
* Tweak: Added Skip Links and `#content` for the main wrapper for better accessibility ([#133](https://github.com/elementor/hello-theme/issues/133))
102+
* Tweak: Added underline for text links in Post Content for better accessibility
100103
* Tweak: Removed `outline: none` from inputs for better accessibility
101104
* Fix: Footer menu location is not being presented on sites that are not running Elementor
102105

0 commit comments

Comments
 (0)