Skip to content

Commit

Permalink
Tweak: Added Skip to Content link to dynamic or template header (#209)
Browse files Browse the repository at this point in the history
* few comments

* Tested up to 5.6

* remove duplicate

* add utilities scss

* Post Password Form Submit button alignment

When a post is password-protected, the Post Password Form Submit button isn't aligned properly.

* Update Changelog

* Move Hello Theme Header & Footer experiment to stable status

* Changelog

* Build

* Add ref to changelog

* Aligned page title to the header and footer

* Internal: Add accessibility-ready tag

* Tweak: Remove unused image file

* Internal: update text & links

* Internal: fix URL

* Tweak: Mark the header footer tab in the customizer

* Fix: Remove override the default width

* Changelog

* Tweak: Add theme_support for `script` and `style` to avoid validation warnings (#184)

* A different way to align title

* changelog

* Tweak: Add output escaping, fixed: #194

* Tweak: Added Skip to Content link to dynamic or template header

* Changelog

* Update header.php

Co-authored-by: Roman <[email protected]>
Co-authored-by: Yakir Sitbon <[email protected]>
  • Loading branch information
3 people authored Jul 6, 2022
1 parent f1d9485 commit e46ce95
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 5 deletions.
7 changes: 5 additions & 2 deletions header.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,12 @@
</head>
<body <?php body_class(); ?>>

<?php
hello_elementor_body_open();
<?php hello_elementor_body_open(); ?>

<a class="skip-link screen-reader-text" href="#content">
<?php esc_html_e( 'Skip to content', 'hello-elementor' ); ?></a>

<?php
if ( ! function_exists( 'elementor_theme_do_location' ) || ! elementor_theme_do_location( 'header' ) ) {
if ( did_action( 'elementor/loaded' ) && hello_header_footer_experiment_active() ) {
get_template_part( 'template-parts/dynamic-header' );
Expand Down
5 changes: 4 additions & 1 deletion readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,12 @@ Source: https://stocksnap.io/photo/4B83RD7BV9
== Changelog ==

= 2.6.0 - 2022-07-XX =
* Tweak: Added `theme_support` for `script` and `style` to avoid validation warnings ([#184](https://github.com/elementor/hello-theme/issues/184))
* Tweak: Sanitize content for allowed HTML tags in post title ([#118](https://github.com/elementor/hello-theme/issues/118))
* Tweak: Changed the containers to `max-width: 1140px` instead of `960px` to align with the header-footer width
Tweak: Centering the page title for better consistency in some cases
* Tweak: Centering the page title for better consistency in all cases
* Tweak: Added link between the customizer to Elementor global settings
* Fix: Added output escaping in several places ([#194](https://github.com/elementor/hello-theme/issues/194))
* Fix: Post Password Form Submit button alignment (Props [@romanbondar](https://github.com/romanbondar))

= 2.5.0 - 2022-01-26 =
Expand Down
2 changes: 0 additions & 2 deletions template-parts/header.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
'echo' => false,
] );
?>
<a class="skip-link screen-reader-text" href="#content">
<?php esc_html_e( 'Skip to content', 'hello-elementor' ); ?></a>

<header id="site-header" class="site-header" role="banner">

Expand Down

0 comments on commit e46ce95

Please sign in to comment.