Configure the AuthenticationService later now that we have 2 flows on the start screen. #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 5af32d9 |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
pixlwave
force-pushed
the
doug/delay-configure-homeserver
branch
from
b6569a9
to
abe1ecb
Compare
stefanceriu
approved these changes
Sep 24, 2024
|
|
||
| @testable import ElementX | ||
|
|
||
| class AuthenticationServiceTests: XCTestCase { |
| @@ -107,6 +106,8 @@ final class ServerSelectionScreenCoordinator: CoordinatorProtocol { | |||
| viewModel.displayError(.invalidWellKnownAlert(error)) | |||
| case .slidingSyncNotAvailable: | |||
| viewModel.displayError(.slidingSyncAlert) | |||
| case .registrationNotSupported: | |||
| viewModel.displayError(.registrationAlert) // TODO: [DOUG] Test me! | |||
There was a problem hiding this comment.
(I have this already in a follow-up branch).
|
|
||
| // MARK: - Helpers | ||
|
|
||
| private func setupMocks(clientConfiguration: ClientSDKMock.Configuration = .init()) { |
| // MARK: - Mocks | ||
|
|
||
| extension AuthenticationService { | ||
| static var mock = AuthenticationService(userSessionStore: UserSessionStoreMock(configuration: .init()), |
| @@ -11,5 +11,117 @@ import XCTest | |||
|
|
|||
| @MainActor | |||
| class ServerConfirmationScreenViewModelTests: XCTestCase { | |||
Implement basic tests for configuration & password login.
pixlwave
force-pushed
the
doug/delay-configure-homeserver
branch
from
abe1ecb
to
5af32d9
Compare
|
|
Merging this as the snapshot failures are emoji provider flakiness. Going to spend some time on these failures now. |
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first of a series to re-work the authentication flow:
AuthenticationStartScreen. Instead we do it either when selecting a server, or if this hasn't happened, when continuing to use the default homeserver. (This lines up with how the flow works on Android).ClientSDKMock.MockAuthenticationServicewith the real one in all of our tests.AuthenticationServiceandServerConfirmationScreenViewModel.Fixes #3028 from the perspective of if matrix.org is blocked (although that long timeout still needs addressing if you were to tap continue to try matrix.org in this instance.
More tests to follow, but this PR has already grown larger than I would have liked. Definitely one to review commit-by-commit.