Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long timeout before proceeding to change account provider screen when matrix.org URL is blocked or inaccessible #3028

Closed
aki-mizu opened this issue Jul 12, 2024 · 3 comments · Fixed by #3316
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue

Comments

@aki-mizu
Copy link

Steps to reproduce

  1. Where are you starting? What can you see?
    The launch screen with Sign in manually button
  2. What do you click?
    Sign in manually button

Outcome

What did you expect?

I should be able to change account provider regardless matrix.org is accessible or not.
In Android Element X latest version, this issues does not occur.

What happened instead?

The loading indicator keeps going on forever when Sign in manually button is tapped while matrix.org is inaccessible.

Your phone model

iPhone 11

Operating system version

iOS 17.5.1

Application version

1.16.13

Homeserver

No response

Will you send logs?

No

@pixlwave
Copy link
Member

pixlwave commented Jul 12, 2024

Ah, seems like we have a behaviour change here, you can still change your homeserver but if requests to matrix.org are dropped rather than rejected then the we need to wait for it to timeout to know that it is unavailable. This used to be 30-seconds but recent changes have meant it now retries twice more and then proceeds to make a different request so we've gone from 30-seconds to 3-minutes which is clearly too long.

@pixlwave pixlwave added A-Authentication S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue labels Jul 12, 2024
@pixlwave pixlwave changed the title Cannot proceed to change account provider screen when matrix.org URL is blocked or inaccessible Long timeout before proceeding to change account provider screen when matrix.org URL is blocked or inaccessible Jul 12, 2024
@aki-mizu
Copy link
Author

Just wondering is it necessary that requests to matrix.org must be made before users are allowed to switch account providers?
Asking this because on android EX this apparently isn’t the case, so this issue occurs only on iOS.

@tearfulDalvik
Copy link

I think we can try to reduce the 3-minute timeout to seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Authentication O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Rust This issue needs a Rust SDK change. It must have a link to a Rust SDK issue
Projects
None yet
3 participants