Use the new RtcNotification event instead of the now deprecated CallNotify #5357

BillCarsonFr · 2025-09-16T07:03:40Z

Implements MSC4075

A new event m.rtc.notification is proposed which can be sent by a client that wants to notify others about the existence of a session for a MatrixRTC application.

Based on #5305
Depends on rust sdk matrix-org/matrix-rust-sdk#5668
and ruma ruma/ruma#2199

Content

Motivation and context

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

Physical
Emulator
OS version(s):

Checklist

Changes have been tested on an Android device or Android emulator with API 24
UI change has been tested on both light and dark themes
Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
Pull request is based on the develop branch
Pull request title will be used in the release note, it clearly define what will change for the user
Pull request includes screenshots or videos if containing UI changes
You've made a self review of your PR

github-actions · 2025-09-17T13:37:16Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/A8Eaci

jmartinesp

Thanks for the changes. I have a few comments, and I think you also need to fix the tests (you can run them with ./gradlew testDebugUnitTest).

jmartinesp · 2025-09-17T13:35:10Z

...s/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt

        mutex.withLock {
+            val ringDuration =
+                min(
+                    notificationData.expirationTimestamp - System.currentTimeMillis(),


I think you need to use SystemClock here.

...s/call/impl/src/main/kotlin/io/element/android/features/call/impl/utils/ActiveCallManager.kt

jmartinesp · 2025-09-17T13:37:48Z

...api/src/main/kotlin/io/element/android/libraries/matrix/api/notification/NotificationData.kt

            val senderId: UserId,
        ) : MessageLike

        data class CallNotify(


Shouldn't we rename this too?

done in this commit 1a7ce36

...atrix/impl/src/main/kotlin/io/element/android/libraries/matrix/impl/timeline/RustTimeline.kt

jmartinesp · 2025-09-18T08:11:44Z

Something definitely broke this time 😅 . It seems like it's conflicting imports?

jmartinesp

Thanks, let's hope it passes the CI this time 🤞 .

sonarqubecloud · 2025-09-18T12:41:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ElementBot · 2025-09-18T12:49:34Z

	Warnings
⚠️	gradle/libs.versions.toml#L7 - A newer version of com.android.tools.build:gradle than 8.11.1 is available: 8.13.0. (There is also a newer version of 8.11.𝑥 available, if upgrading to 8.13.0 is difficult: 8.11.2)
⚠️	gradle/libs.versions.toml#L9 - A newer version of org.jetbrains.kotlin.plugin.serialization than 2.2.10 is available: 2.2.20
⚠️	gradle/libs.versions.toml#L19 - A newer version of androidx.lifecycle:lifecycle-runtime-ktx than 2.9.2 is available: 2.9.4
⚠️	gradle/libs.versions.toml#L25 - A newer version of androidx.compose:compose-bom than 2025.07.00 is available: 2025.09.00
⚠️	gradle/libs.versions.toml#L47 - A newer version of me.saket.telephoto:zoomable-image-coil than 0.16.0 is available: 0.17.0
⚠️	gradle/libs.versions.toml#L51 - A newer version of com.autonomousapps:dependency-analysis-gradle-plugin than 2.19.0 is available: 3.0.4
⚠️	gradle/libs.versions.toml#L54 - A newer version of dev.zacsweers.metro:runtime than 0.6.4 is available: 0.6.6
⚠️	gradle/libs.versions.toml#L61 - A newer version of org.jetbrains.kotlinx:kover-gradle-plugin than 0.9.1 is available: 0.9.2
⚠️	gradle/libs.versions.toml#L157 - A newer version of org.robolectric:robolectric than 4.15.1 is available: 4.16
⚠️	gradle/libs.versions.toml#L201 - A newer version of com.posthog:posthog-android than 3.21.2 is available: 3.21.3
⚠️	libraries/push/impl/src/main/kotlin/io/element/android/libraries/push/impl/notifications/factories/NotificationCreator.kt#L469 - Use the KTX function `createBitmap` instead?

Generated by 🚫 dangerJS against b13c93f

codecov · 2025-09-18T12:59:38Z

Codecov Report

❌ Patch coverage is 64.81481% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.74%. Comparing base (0d7d33c) to head (b13c93f).
⚠️ Report is 9 commits behind head on develop.

Files with missing lines	Patch %	Lines
...cation/TimelineEventToNotificationContentMapper.kt	0.00%	6 Missing and 1 partial ⚠️
...mpl/notifications/CallNotificationEventResolver.kt	66.66%	0 Missing and 2 partials ⚠️
...eatures/messages/impl/actionlist/ActionListView.kt	0.00%	1 Missing ⚠️
...ssages/impl/timeline/components/TimelineItemRow.kt	0.00%	0 Missing and 1 partial ⚠️
...e/components/event/TimelineItemEventContentView.kt	0.00%	0 Missing and 1 partial ⚠️
...line/factories/event/TimelineItemContentFactory.kt	0.00%	1 Missing ⚠️
...ures/messages/impl/timeline/groups/Groupability.kt	0.00%	0 Missing and 1 partial ⚠️
...l/timeline/model/event/TimelineItemEventContent.kt	0.00%	0 Missing and 1 partial ⚠️
.../messages/impl/timeline/protection/TimelineItem.kt	0.00%	0 Missing and 1 partial ⚠️
...s/messagesummary/DefaultMessageSummaryFormatter.kt	0.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #5357   +/-   ##
========================================
  Coverage    79.73%   79.74%           
========================================
  Files         2274     2274           
  Lines        62867    62888   +21     
  Branches      7874     7875    +1     
========================================
+ Hits         50130    50149   +19     
- Misses        9840     9842    +2     
  Partials      2897     2897

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BillCarsonFr self-assigned this Sep 16, 2025

BillCarsonFr added the PR-Change For updates to an existing feature label Sep 16, 2025

Base automatically changed from feature/valere/rtc/call_deline to develop September 16, 2025 08:25

BillCarsonFr added 2 commits September 17, 2025 15:15

Use the new RtcNotification instead of deprecated CallNotify

508aef9

bump rust component version

d350a55

BillCarsonFr force-pushed the feature/valere/rtc/new_notification branch from 2a1a5c5 to d350a55 Compare September 17, 2025 13:29

BillCarsonFr marked this pull request as ready for review September 17, 2025 13:31

BillCarsonFr requested a review from a team as a code owner September 17, 2025 13:31

BillCarsonFr requested review from jmartinesp and removed request for a team September 17, 2025 13:31

jmartinesp requested changes Sep 17, 2025

View reviewed changes

fix test compilation

277602f

bmarty mentioned this pull request Sep 17, 2025

Update dependency org.matrix.rustcomponents:sdk-android to v25.9.17 #5362

Closed

1 task

BillCarsonFr added 2 commits September 18, 2025 09:18

review + tests

be52447

refactor: rename CallNotify to RtcNotification to match new event

1a7ce36

BillCarsonFr requested a review from jmartinesp September 18, 2025 07:25

BillCarsonFr added 2 commits September 18, 2025 12:25

fix Conflicting import

6052d45

Fix wrong expiration default that was breaking tests

f7b7328

jmartinesp approved these changes Sep 18, 2025

View reviewed changes

fix the tests

b13c93f

BillCarsonFr merged commit d30f385 into develop Sep 18, 2025
29 of 31 checks passed

BillCarsonFr deleted the feature/valere/rtc/new_notification branch September 18, 2025 13:23

Use the new RtcNotification event instead of the now deprecated CallNotify #5357

Use the new RtcNotification event instead of the now deprecated CallNotify #5357

Uh oh!

Conversation

BillCarsonFr commented Sep 16, 2025

Content

Motivation and context

Screenshots / GIFs

Tests

Tested devices

Checklist

Uh oh!

github-actions bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmartinesp left a comment

Choose a reason for hiding this comment

Uh oh!

jmartinesp Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmartinesp Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

BillCarsonFr Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmartinesp commented Sep 18, 2025

Uh oh!

jmartinesp left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Sep 18, 2025

Quality Gate passed

Uh oh!

ElementBot commented Sep 18, 2025

Uh oh!

codecov bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Sep 17, 2025 •

edited

Loading

codecov bot commented Sep 18, 2025 •

edited

Loading