feat(rtc): Remove deprecated CallNotify in favour of RtcNotification

[BillCarsonFr]

CallNotify event has been deprecated in favour of RtcNotification event ruma/ruma#2199

Needs an update on ruma dependency

• Public API changes documented in changelogs (optional)

Signed-off-by:

[codspeed-hq]

CodSpeed Performance Report

Merging #5668 will not alter performance

_{Comparing valere/call/new_rtc_notification (a0cffc6) with main (8c6922d)}

Summary

✅ 49 untouched

[codecov]

Codecov Report

❌ Patch coverage is 64.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.36%. Comparing base (b8cbd6c) to head (a0cffc6).
⚠️ Report is 22 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...trix-sdk-ui/src/timeline/event_item/content/mod.rs	0.00%	7 Missing ⚠️
crates/matrix-sdk-ui/src/timeline/event_handler.rs	0.00%	1 Missing ⚠️
...rates/matrix-sdk-ui/src/timeline/event_item/mod.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5668      +/-   ##
==========================================
- Coverage   88.37%   88.36%   -0.01%     
==========================================
  Files         355      355              
  Lines       97476    97476              
  Branches    97476    97476              
==========================================
- Hits        86146    86138       -8     
- Misses       7264     7272       +8     
  Partials     4066     4066              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bnjbvr]

Thanks. Two minor comments below, and a few extra questions:

• being unaware of the MSC et al., does this maintain backwards compatibility with the existing system and events?
• linked to the other question: does it require a timed merge with an Element Call release, or can this PR be merged at any time?

[bnjbvr]

Should it be renamed Notification to align with Ruma?

[BillCarsonFr]

right, done 9d53bc1

[bnjbvr]

The more idiomatic way with the EventFactory builder pattern would be to add fn mentions() and fn rtc_membership_event() methods on impl EventBuilder<RtcNotificationEventContent>, so that we don't have Optional parameters in this ctor. Also, I would rather make it so that the timestamp and durations are configurable (aka function parameters), so we don't have tight coupling between the test framework and the tests themselves (or, at least let's rename rtc_notification to predefined_rtc_notification or something like that)

[BillCarsonFr]

Thanks for all the tips! I missed the fact that one could do impl EventBuilder<CONTENT>.
Done here 0505ce2

[BillCarsonFr]

Thanks. Two minor comments below, and a few extra questions:

* being unaware of the MSC et al., does this maintain backwards compatibility with the existing system and events?

* linked to the other question: does it require a timed merge with an Element Call release, or can this PR be merged at any time?

Good Q. Given that EC is already sending both the old mscXXX.call.decline as well as the new mscXXX.rtc.notification, we decided that we don't need to support both nor to require timed merged. It can be merged anytime

[bnjbvr]

Perfect then, thanks!