Skip to content

Conversation

@BillCarsonFr
Copy link
Member

@BillCarsonFr BillCarsonFr commented Sep 9, 2025

Fixes #5307
Fixes #5308

Depends on rust-sdk matrix-org/matrix-rust-sdk#5614

Adds support for declining calls:

  • When receiving an incoming call, the red decline button will now send a x.msc4310.rtc.decline event in the room.
  • When EX starts ringing it will also start listening for incoming .rtc.decline in order to stop ringing if the call was declined from another session

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@BillCarsonFr BillCarsonFr added T-Task Refactoring, enabling or disabling functionality, other engineering tasks PR-Feature For a new feature labels Sep 9, 2025
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/rtc/call_deline branch from 361d6d9 to d50b17e Compare September 10, 2025 07:12
@BillCarsonFr BillCarsonFr force-pushed the feature/valere/rtc/call_deline branch from d50b17e to e20b355 Compare September 11, 2025 11:33
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/TpMbho

@codecov
Copy link

codecov bot commented Sep 11, 2025

Codecov Report

❌ Patch coverage is 67.30769% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.63%. Comparing base (87c8c57) to head (5bbe299).
⚠️ Report is 34 commits behind head on develop.

Files with missing lines Patch % Lines
...android/libraries/matrix/impl/room/RustBaseRoom.kt 0.00% 8 Missing ⚠️
...roid/features/call/impl/utils/ActiveCallManager.kt 80.55% 2 Missing and 5 partials ⚠️
...droid/libraries/matrix/impl/room/join/AllowRule.kt 0.00% 1 Missing ⚠️
...android/libraries/matrix/test/room/FakeBaseRoom.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5305      +/-   ##
===========================================
- Coverage    79.64%   79.63%   -0.01%     
===========================================
  Files         2259     2259              
  Lines        62499    62546      +47     
  Branches      7833     7843      +10     
===========================================
+ Hits         49779    49811      +32     
- Misses        9854     9865      +11     
- Partials      2866     2870       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BillCarsonFr BillCarsonFr marked this pull request as ready for review September 11, 2025 12:12
@BillCarsonFr BillCarsonFr requested a review from a team as a code owner September 11, 2025 12:12
@BillCarsonFr BillCarsonFr requested review from bmarty and removed request for a team September 11, 2025 12:12
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have pushed a few commits, let me know if it's OK for you @BillCarsonFr

@sonarqubecloud
Copy link

@BillCarsonFr
Copy link
Member Author

Thanks. I have pushed a few commits, let me know if it's OK for you @BillCarsonFr

All good, thx for the clean up !

@BillCarsonFr BillCarsonFr merged commit 5d11540 into develop Sep 16, 2025
30 of 35 checks passed
@BillCarsonFr BillCarsonFr deleted the feature/valere/rtc/call_deline branch September 16, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Feature For a new feature T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

3 participants