-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Render M_SAFETY errors (MSC4387) #31558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
03be33e to
3168186
Compare
4602c3f to
16eb46f
Compare
|
Given this isn't in labs it'll want design/product sign-off |
jimmackenzie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweaks to the error content.
| WithMessageRejectedWithServerMessage.args = { | ||
| state: RoomStatusBarState.MessageRejected, | ||
| harms: ["any.old.harm"], | ||
| serverError: "OurServer rejects this content", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is OurServerreplaced with the server name via text interpolation? If not, we should reword this:
This content is not permitted perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the error the server is returning. I think the MSC says that if the harm isn't known, we should defer to the server's message?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the MSC says that if the harm isn't known, we should defer to the server's message?
We shouldn't be showing untranslated server errors ever, this violates some customer commitments we have to be fully i18nable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I'll leave feedback on the MSC. It doesn't appear to be a must so we can use generic wording for this.
Co-authored-by: Jim Mackenzie <[email protected]>
turt2live
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deferring strings review to Jim as the more qualified person :)
Requires #31523Requires matrix-org/matrix-js-sdk#5107Uses MSC4387
Renders the new MSC4387 safety errors where we would usually render generic message failed to send errors, the specifics are:
Reviewer notes:
Checklist
public/exportedsymbols have accurate TSDoc documentation.