-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Render M_SAFETY errors (MSC4387) #31558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Half-Shot
wants to merge
47
commits into
develop
Choose a base branch
from
hs/safety-error-code
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
7d92f0c
Refactor RoomStatusBar into MVVM
Half-Shot 1fde8bf
cleanup
Half-Shot c595acc
updated snaps
Half-Shot 3270e87
More cleanup
Half-Shot 73f157d
fix loop
Half-Shot 1d1a8a8
fixup
Half-Shot 2f1d28b
drop comment
Half-Shot 7f0306f
lint
Half-Shot 6638f2f
cleanup console statements
Half-Shot 9191346
Starting to move to a MVVM v2 component.
Half-Shot 1571360
extra
Half-Shot e449a9d
Refactor as a shared-componend / MVVM v2
Half-Shot 7ce4f49
some cleanup
Half-Shot c799ee2
i18n for banner
Half-Shot 29b787a
remove removed css
Half-Shot 6cc9e3e
Update playwright tests to have a two stage on the consent bar.
Half-Shot 3168186
Update snaps
Half-Shot 335498d
Update snapshots
Half-Shot c3bcc54
cleanup
Half-Shot e6aca3f
update snaps
Half-Shot 1b744d0
refactor to use enum
Half-Shot 6fe5109
fix slight differences in pw snaps
Half-Shot bec3a3b
Add unit tests
Half-Shot ecc4671
Merge remote-tracking branch 'origin/develop' into hs/roomstatusbar-vm
Half-Shot 847cc91
fix snaps
Half-Shot 768a731
snaps updated
Half-Shot 5c5f899
more test cleanups
Half-Shot 401383a
fix snaps
Half-Shot 5fdf04f
Merge remote-tracking branch 'origin/develop' into hs/roomstatusbar-vm
Half-Shot 72cb271
fixed now?
Half-Shot 22b68bf
Disable animationsq
Half-Shot 940f5be
lint lint lint
Half-Shot 73d21b1
remove console
Half-Shot 14e1f97
lint
Half-Shot 39a9d52
fix snap
Half-Shot f58da18
Add safety views.
Half-Shot 3a76a99
Add safety test.
Half-Shot 74b78bf
Update view model
Half-Shot 16eb46f
misc updates
Half-Shot 224ebb8
Merge remote-tracking branch 'origin/develop' into hs/safety-error-code
Half-Shot 4d0f9a3
Revert snap changes
Half-Shot acb4583
Remove unused
Half-Shot b5b2aad
lint
Half-Shot 823814a
Update snaps
Half-Shot 1d70933
resending ficx
Half-Shot 7b76628
Fix playwright barfing on js-sdk
Half-Shot ef8bf8a
Update packages/shared-components/src/i18n/strings/en_EN.json
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file added
BIN
+24.6 KB
...shots/room-roomstatusbarview--with-message-rejected-can-retry-in-time-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+25 KB
...ght/snapshots/room-roomstatusbarview--with-message-rejected-can-retry-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.1 KB
...ts/playwright/snapshots/room-roomstatusbarview--with-message-rejected-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+20.4 KB
...right/snapshots/room-roomstatusbarview--with-message-rejected-sending-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.4 KB
...apshots/room-roomstatusbarview--with-message-rejected-with-known-harm-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+23.2 KB
...ots/room-roomstatusbarview--with-message-rejected-with-server-message-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
OurServerreplaced with the server name via text interpolation? If not, we should reword this:This content is not permittedperhaps?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just the error the server is returning. I think the MSC says that if the harm isn't known, we should defer to the server's message?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't be showing untranslated server errors ever, this violates some customer commitments we have to be fully i18nable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, I'll leave feedback on the MSC. It doesn't appear to be a must so we can use generic wording for this.