Refactor RoomStatusBar into MVVM #31523
Open
+1,642
−1,022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Half-Shot
commented
Dec 16, 2025
Half-Shot
commented
Dec 18, 2025
| import { MatrixClientPeg } from "../../src/MatrixClientPeg"; | ||
| import { mkThread } from "../test-utils/threads"; | ||
|
|
||
| describe("getUnsentMessages", () => { |
Member
Author
There was a problem hiding this comment.
This is just a copy paste of the tests to match the move of getUnsentMessages to the other file.
Half-Shot
commented
Dec 18, 2025
| describe("computed attributes", () => { | ||
| beforeEach(() => { | ||
| jest.spyOn(RoomStatusBarModule, "getUnsentMessages").mockReturnValue([]); | ||
| jest.spyOn(room, "getPendingEvents").mockReturnValue([]); |
Member
Author
There was a problem hiding this comment.
Spying on the whole module was unnessacery when the influencing factor of getUnsentMessages was mostly whether getPendingEvents had any events.
It also broke due to the fragility mocking whole imports, so I've converted it to a much more stable mock.
5 tasks
florianduros
reviewed
Jan 5, 2026
packages/shared-components/src/room/RoomStatusBar/RoomStatusBarView.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/room/RoomStatusBar/RoomStatusBarView.tsx
Outdated
Show resolved
Hide resolved
packages/shared-components/src/room/RoomStatusBar/RoomStatusBarView.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring the room status bar into a proper shared-component / MVVM thing work will be used to eventually start rendering safety errors for MSC4387.
This also changes the styling of quite a few of our room status banners into proper Compound ones, utilising the Banner.
See snapshots for changes