Playwright: factor out helpers for config.json#81
Merged
Conversation
Factor out some helper functions for building `config.json` files, and adding the relevant routes to browser contexts.
richvdh
force-pushed
the
rav/config_json_funcs
branch
from
ea95c21 to
9bc44e7
Compare
dbkr
approved these changes
Oct 3, 2025
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 3, 2025
element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 3, 2025
element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 3, 2025
element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it.
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Oct 6, 2025
element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it.
github-merge-queue bot
pushed a commit
to element-hq/element-web
that referenced
this pull request
Oct 8, 2025
* Playwright: `getCurrentRoomIdFromUrl` Helper function to fish a room ID out of the URL * Playwright: use updated `Credentials` class from common lib Pick up the extended `Credentials` interface that was added in element-hq/element-modules#80. * Playwright: use `routeConfigJson` from common lib element-hq/element-modules#81 added a utility function for building and routing `config.json`; we should use it. * Playwright test for history sharing on invite Fixes element-hq/element-meta#2920 * Avoid use of CSS in playwright locators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factor out some helper functions for building
config.jsonfiles, and adding the relevant routes to browser contexts.