Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer doesn't work with many input methods #7665

Closed
turt2live opened this issue Nov 5, 2018 · 21 comments
Closed

Composer doesn't work with many input methods #7665

turt2live opened this issue Nov 5, 2018 · 21 comments

Comments

@turt2live
Copy link
Member

turt2live commented Nov 5, 2018

Input methods (aka IMEs) from various operating systems and keyboard layouts cause problems with Riot. The symptoms include flashing characters, losing focus, misrepresentation of characters, etc.

This is all tracked as an upstream issue: ianstormtaylor/slate#2368

Here's what we have:

@turt2live
Copy link
Member Author

I think I got all of them. Please point out any issues I might have missed.

@mvgorcum
Copy link

mvgorcum commented Nov 6, 2018

you missed #7149

@turt2live
Copy link
Member Author

#7149 is a duplicate of another issue on this list.

@ghost
Copy link

ghost commented Nov 13, 2018

Just so you know that I'm now experiencing the same characters problem with macOS 10.14.1, Safari 12.0.1 & the US Intl keymap. Very annoying indeed.

out

@ghost
Copy link

ghost commented Feb 19, 2019

I can confirm this issue on NixOS, Firefox, and Fcitx with Mozc for Japanese input. Whatever I type is stochastically swallowed and I would sadly say that things are unusable at this point, if I want to type in Japanese I will have to type it in another window and paste it into the Riot web client.

@palytoxin
Copy link

I have the same problem on macos.

@kiliankoe
Copy link

I'm not sure about the progress that was made here, but I've noticed that typing umlauts is now possible. A new issue however is that I'm often unable to use backspace, or sometimes type at all, unless I restart Riot. The app doesn't freeze up or anything like that, some forms of input just no longer work in the message field.

@kiliankoe
Copy link

kiliankoe commented Mar 12, 2019

text

I have to restart/reload Riot several times daily when it gets itself into a weird state regarding text input 😕 Often this happens after typing German umlauts, suddenly I can't use backspace, or typing doesn't work at all, or text just reappears after deleting it (as shown in the gif). This feels extremely broken.

IMO the message input is doing way too much magic, whatever it's trying to achieve with that. It should just be a basic text field that works.

@kiliankoe
Copy link

kiliankoe commented Mar 15, 2019

Sorry for piling ever more comments onto this issue, but I've noticed that I've been invoking cmda + backspace twice to delete an entire message, since it always fails the first time 😕

@aaronraimist
Copy link
Collaborator

Someone should try to update to the latest version of Slate. The upstream issue isn't fixed but people keep reporting that it is better on the latest versions.

@longfan3
Copy link

longfan3 commented Apr 3, 2019

@aaronraimist @turt2live When i try to update the Slate to 0.44.12, I got the error :
As of Slate 0.42.0, value object are no longer schema-aware, and the `value.change()` method is no longer available. Use the `editor.change()` method on the new `Editor` controller instead.
Do you have a related upgrade plan?

@ghost
Copy link

ghost commented Sep 12, 2019

I didn't want to open yet another issue, but just wanna ping that input doesn't work beyond the keys input directly with keypress on the keyboard. I can't input Korean and Chinese via ibus, and X compose key doesn't work either.

@ara4n
Copy link
Member

ara4n commented Sep 16, 2019

let the record show that we're solving this by moving away from Slate to a lightweight editor we wrote ourselves called CIDER. Please help us test it by going to riot.im/develop and turning on the new editor in Labs in Settings, and hopefully almost all of these issues are resolved.

@xuhdev
Copy link

xuhdev commented Sep 16, 2019

@ara4n I went to riot.im/develop but the issue still persists...

@jryans
Copy link
Collaborator

jryans commented Sep 16, 2019

@ara4n I went to riot.im/develop but the issue still persists...

Sorry to be pedantic, but did you also go to Settings -> Labs, enable the new composer, and reload Riot? (The new composer is not enabled by default yet.)

@xuhdev
Copy link

xuhdev commented Sep 16, 2019

@jryans That works! Thanks!

@ghost
Copy link

ghost commented Sep 16, 2019

Works! Gonna take a while to beat my input-phobia now :D

@rixtox
Copy link

rixtox commented Sep 17, 2019

Here is a normal input sequence:

But the behavior in CIDER is:

@cetex
Copy link

cetex commented Sep 17, 2019

let the record show that we're solving this by moving away from Slate to a lightweight editor we wrote ourselves called CIDER. Please help us test it by going to riot.im/develop and turning on the new editor in Labs in Settings, and hopefully almost all of these issues are resolved.

Sweet!

The new one seems to work much better from ~2minutes of testing, now i can even paste stuff into the riot.im message-field on Qutebrowser / linux/wayland (sway) without having to open webinspector -> elements -> event listeners -> remove listener on paste, paste my stuff, post, then reload riot.im to make it work for normal messaging again..

@bwindels
Copy link
Contributor

Thanks @rixtox, have split this out into a separate issue: #10913

@turt2live
Copy link
Member Author

🎉 🎉 🎉 fixed 🎉 🎉 🎉

su-ex added a commit to SchildiChat/element-web that referenced this issue Feb 15, 2022
* Support a config option to change the default device name ([\element-hq#20790](element-hq#20790)).
* Capitalize "Privacy" in UserMenu ([\element-hq#7738](matrix-org/matrix-react-sdk#7738)). Contributed by @aaronraimist.
* Move new search experience to a Beta ([\#7718](matrix-org/matrix-react-sdk#7718)). Fixes element-hq/element-meta#139 element-hq#20618 and element-hq#20339.
* Auto select "Other homeserver" when user press "Edit" in homeserver field ([\element-hq#7337](matrix-org/matrix-react-sdk#7337)). Fixes element-hq#20125. Contributed by @SimonBrandner.
* Add unread badges and avatar decorations to spotlight search ([\element-hq#7696](matrix-org/matrix-react-sdk#7696)). Fixes element-hq#20821.
* Enable location sharing ([\element-hq#7703](matrix-org/matrix-react-sdk#7703)).
* Simplify Composer buttons ([\element-hq#7678](matrix-org/matrix-react-sdk#7678)).
* Add a warning to the console to discourage attacks and encourage contributing ([\element-hq#7673](matrix-org/matrix-react-sdk#7673)). Fixes element-hq#2803. Contributed by @SimonBrandner.
* Don't show replaced calls in the timeline ([\element-hq#7452](matrix-org/matrix-react-sdk#7452)). Contributed by @SimonBrandner.
* Tweak `/addwidget` widget names ([\element-hq#7681](matrix-org/matrix-react-sdk#7681)).
* Chat export parameter customisation ([\element-hq#7647](matrix-org/matrix-react-sdk#7647)).
* Put call on hold when transfer dialog is opened ([\element-hq#7669](matrix-org/matrix-react-sdk#7669)).
* Share e2ee keys when using /invite SlashCommand ([\element-hq#7655](matrix-org/matrix-react-sdk#7655)). Fixes element-hq#20778 and element-hq#16982.
* Tweak spotlight roving behaviour to reset when changing query ([\#7656](matrix-org/matrix-react-sdk#7656)). Fixes element-hq#20537 element-hq#20612 and element-hq#20184.
* Look up tile server info in homeserver's .well-known area ([\element-hq#7623](matrix-org/matrix-react-sdk#7623)).
* Add grouper for hidden events ([\element-hq#7649](matrix-org/matrix-react-sdk#7649)).
* The keyboard shortcut is control (or cmd) shift h. ([\element-hq#7584](matrix-org/matrix-react-sdk#7584)). Contributed by @UwUnyaa.
* [Release] Fix cutout misalignment on some decorated room avatars ([\element-hq#7785](matrix-org/matrix-react-sdk#7785)).
* [Release] Fix add existing space not showing any spaces ([\element-hq#7756](matrix-org/matrix-react-sdk#7756)).
* [Release] Inhibit Room List keyboard pass-thru when the search beta is enabled ([\element-hq#7754](matrix-org/matrix-react-sdk#7754)).
* [Release] Fix space member list not opening ([\element-hq#7755](matrix-org/matrix-react-sdk#7755)).
* Null-guard ELS from null summaryMembers ([\element-hq#7744](matrix-org/matrix-react-sdk#7744)). Fixes element-hq#20807.
* Improve responsiveness of the layout switcher ([\element-hq#7736](matrix-org/matrix-react-sdk#7736)).
* Tweak timeline card layout ([\element-hq#7743](matrix-org/matrix-react-sdk#7743)). Fixes element-hq#20846.
* Ensure location bodies have a width in bubbles ([\element-hq#7742](matrix-org/matrix-react-sdk#7742)). Fixes element-hq#20916.
* Tune aria-live regions around clocks/timers ([\element-hq#7735](matrix-org/matrix-react-sdk#7735)). Fixes element-hq#20967.
* Fix instances of decorated room avatar wrongly having their own tabIndex ([\element-hq#7730](matrix-org/matrix-react-sdk#7730)).
* Remove weird padding on stickers ([\element-hq#6271](matrix-org/matrix-react-sdk#6271)). Fixes element-hq#17787. Contributed by @SimonBrandner.
* Fix width issue of the composer overflow menu items ([\element-hq#7731](matrix-org/matrix-react-sdk#7731)). Fixes element-hq#20898.
* Properly handle persistent widgets when room is left ([\element-hq#7724](matrix-org/matrix-react-sdk#7724)). Fixes element-hq#20901.
* Null guard space hierarchy ([\element-hq#7729](matrix-org/matrix-react-sdk#7729)). Fixes matrix-org/element-web-rageshakes#10433.
* Fix add existing rooms button ([\element-hq#7728](matrix-org/matrix-react-sdk#7728)). Fixes element-hq#20924. Contributed by @SimonBrandner.
* Truncate long server names on login/register screen ([\element-hq#7702](matrix-org/matrix-react-sdk#7702)). Fixes element-hq#18452.
* Update PollCreateDialog-test to snapshot the html and not react tree ([\element-hq#7712](matrix-org/matrix-react-sdk#7712)).
* Fix creating polls outside of threads ([\element-hq#7711](matrix-org/matrix-react-sdk#7711)). Fixes element-hq#20882.
* Open native room when clicking notification from a virtual room ([\element-hq#7709](matrix-org/matrix-react-sdk#7709)).
* Fix relative link handling in Element Desktop ([\element-hq#7708](matrix-org/matrix-react-sdk#7708)). Fixes element-hq#20783.
* Reuse CopyableText component in all places it can be ([\element-hq#7701](matrix-org/matrix-react-sdk#7701)). Fixes element-hq#20855.
* Fit location into the width of the container ([\element-hq#7705](matrix-org/matrix-react-sdk#7705)). Fixes element-hq#20861.
* Make Spotlight Dialog roving reset more stable ([\element-hq#7698](matrix-org/matrix-react-sdk#7698)). Fixes element-hq#20826.
* Fix incorrect sizing of DecoratedRoomAvatar in RoomHeader ([\element-hq#7697](matrix-org/matrix-react-sdk#7697)). Fixes element-hq#20090.
* Use a more correct test for emoji ([\element-hq#7685](matrix-org/matrix-react-sdk#7685)). Fixes element-hq#20824. Contributed by @robintown.
* Fix vertical spacing in `compact` `<ContextMenu>` ([\element-hq#7684](matrix-org/matrix-react-sdk#7684)). Fixes element-hq#20801.
* Fix the sticker picker ([\element-hq#7692](matrix-org/matrix-react-sdk#7692)). Fixes element-hq#20797.
* Fix publishing address wrongly demanding the alias be available ([\element-hq#7690](matrix-org/matrix-react-sdk#7690)). Fixes element-hq#12013 and element-hq#20833.
* Prevent MemberAvatar soft-crashing when rendered with null member prop ([\element-hq#7691](matrix-org/matrix-react-sdk#7691)). Fixes element-hq#20714.
* Ensure UserInfo can be rendered without a room ([\element-hq#7687](matrix-org/matrix-react-sdk#7687)). Fixes element-hq#20830.
* Make polls fill column width in bubbles layout ([\#7661](matrix-org/matrix-react-sdk#7661)). Fixes element-hq#20712.
* Add a background to expanded nick name in IRC layout to make it readable. ([\element-hq#7652](matrix-org/matrix-react-sdk#7652)). Fixes element-hq#20757. Contributed by @UwUnyaa.
* Fix accessibility and consistency of MessageComposerButtons ([\element-hq#7679](matrix-org/matrix-react-sdk#7679)). Fixes element-hq#20814.
* Don't show shield next to deleted messages ([\element-hq#7671](matrix-org/matrix-react-sdk#7671)). Fixes element-hq#20475. Contributed by @SimonBrandner.
* Fix font size of spaces between big emoji ([\element-hq#7675](matrix-org/matrix-react-sdk#7675)). Contributed by @robintown.
* Fix shift-enter repeating last character ([\element-hq#7665](matrix-org/matrix-react-sdk#7665)). Fixes element-hq#17215. Contributed by @SimonBrandner.
* Remove Unpin option from maximised widget context menu ([\element-hq#7657](matrix-org/matrix-react-sdk#7657)).
* Fix new call event grouper implementation for encrypted rooms ([\element-hq#7654](matrix-org/matrix-react-sdk#7654)).
* Fix issue with tile error boundaries collapsing in bubbles layout ([\element-hq#7653](matrix-org/matrix-react-sdk#7653)).
* Fix emojis getting cropped in irc & bubble layouts by anti-zalgo ([\element-hq#7637](matrix-org/matrix-react-sdk#7637)). Fixes element-hq#20744.
* Fix space panel edge gradient not applying on load ([\element-hq#7644](matrix-org/matrix-react-sdk#7644)). Fixes element-hq#20756.
* Fix search results view for layouts other than Group/Modern ([\element-hq#7648](matrix-org/matrix-react-sdk#7648)). Fixes element-hq#20745.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests