Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIDER: Choosing latin input in Chinese IME on OSX removes previous compositions #10913

Closed
bwindels opened this issue Sep 18, 2019 · 8 comments · Fixed by matrix-org/matrix-react-sdk#3477

Comments

@bwindels
Copy link
Contributor

bwindels commented Sep 18, 2019

@rixtox reported a remaining issue with IME input on CIDER:

Here is a normal input sequence:

But the behavior in CIDER is:

@bwindels
Copy link
Contributor Author

bwindels commented Sep 23, 2019

@rixtox I've just been looking into this and have few follow-up questions. I'd greatly appreciate if you'd have a moment to do the following:

  • which browser (and version) are you seeing this on?
  • Could you please input the same sequence on this website: https://danburzo.github.io/input-methods/index.html ?
    Use the "Simple DOM contenteditable" field on the left, and make sure the list is empty before you start typing (hit clear log if not).
    Once done, can you please send a screenshot of the list of events below?

Let me know if you need any help with this. Thank you!

@bwindels bwindels changed the title CIDER: Output for chinese input sequence differs from text editor on macOS CIDER: When choosing latin input in Chinese IME on OSX, previous compositions are removed. Sep 23, 2019
@bwindels bwindels changed the title CIDER: When choosing latin input in Chinese IME on OSX, previous compositions are removed. CIDER: Choosing latin input in Chinese IME on OSX removes previous compositions Sep 23, 2019
@bwindels
Copy link
Contributor Author

bwindels commented Sep 23, 2019

Fwiw, this is what it looks like on Linux/Wayland/GNOME3 (Firefox 69 or Chromium 75)
chinese-ime

@rixtox
Copy link

rixtox commented Sep 25, 2019

@bwindels

Previous test was performed on:
OS: macOS Mojave 10.14.6
IME: Rime 0.14.0
Browser: Chrome Version 77.0.3865.90 (Official Build) (64-bit)

This time I tried on Safari 13.0 (14608.1.49) and the result is even worse:

IME interface doesn't even show up, letters are enterred backward, etc.

Here are the logged key events:

@bwindels
Copy link
Contributor Author

@rixtox Thanks for the feedback. It looks like your test in Safari was done with the old editor (as you have a markdown button). Could you try again after enabling the new editor and refreshing?

Also, is the list of events for safari or chrome?

Thanks again!

@rixtox
Copy link

rixtox commented Sep 25, 2019

@bwindels
OK. I thought the settings would sync to new browser logins. So I tested in Safari again, and this time it's better than Chrome, but still not correct:

As shown in the expected behavior in text editor, the last enter key input is used as a confirmation of choosing latin inputs for the IME, not a new line input. The cursor should stay behind the newly typed latin word "demo". But CIDER on Safari treated it as a new line input and submited the whole input line. As a result there's no chance for me to enter more characters after the "demo" text.

The list of events from my previous comment was from Chrome.

This time I logged the events on Safari too:

@bwindels
Copy link
Contributor Author

bwindels commented Sep 25, 2019

Hi @rixtox , thanks for testing again. We've noticed the same thing in Safari while testing, but I can't see how to fix it for now, so tracking this issue at #10957 for now.

I've just merged matrix-org/matrix-react-sdk#3477 to try to fix the issue you reported in Chrome. If you could try again in Chrome on latest /develop, that would be much appreciated!

@bwindels
Copy link
Contributor Author

Keeping this open until confirmed fixed

@bwindels bwindels reopened this Sep 25, 2019
@rixtox
Copy link

rixtox commented Sep 26, 2019

@bwindels Chrome is working properly now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants