Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent chrome + macOS makes the touchbar flash every time you press a key in the composer #9299

Closed
ara4n opened this issue Mar 27, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4173
Closed

Recent chrome + macOS makes the touchbar flash every time you press a key in the composer #9299

ara4n opened this issue Mar 27, 2019 · 6 comments · Fixed by matrix-org/matrix-react-sdk#4173
Assignees
@jryans
Labels
A-Composer P1 T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Mar 27, 2019

Chrome Version 73.0.3683.86, macOS 10.14.3. It is horrrrrrrrrific
@turt2live
Copy link
Member

My instinct says this might be part of #7665 but only barely.

@lampholder
Copy link
Member

Probably another one to be solved by the Simple, stable composer

@Ai-rin
Copy link

Ai-rin commented Apr 28, 2019

In my case (linux with fcitx as input method framework) it causes quick momentary layout changes every time i press a key. This, and its slowness are driving me crazy.

@aaronraimist
Copy link
Collaborator

(deleted my comment about not being able to reproduce, I actually can reproduce it. It doesn't happen on every key press but it does happen randomly.)

@ara4n
Copy link
Member Author

ara4n commented Feb 20, 2020

i just turned on my touchbar for the first time in about 8 months and was dismayed to discover this is still happening, despite CIDER :( it's literally every keypress.

@bwindels are you surprised that something changes the entire function of the inputbox every time you press a key?

@jryans jryans self-assigned this Mar 4, 2020
@jryans
Copy link
Collaborator

jryans commented Mar 4, 2020

This flickering seems to happen when the composer modifies selection state.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Mar 4, 2020
@jryans
Fix composer touch bar flickering on keypress in Chrome
7ad8eeb 
This changes our selection state handling to leave things alone if the browser's
state already matches what we want. This avoids strange side effects like the
touch bar flickering on each key press in Chrome.

Fixes element-hq/element-web#9299
@jryans jryans mentioned this issue Mar 4, 2020
Merged
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@t3chguy t3chguy mentioned this issue Nov 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Composer P1 T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix composer touch bar flickering on keypress in Chrome matrix-org/matrix-react-sdk
6 participants
@jryans @turt2live @ara4n @lampholder @aaronraimist @Ai-rin