fix: dependency path is undefined#9013
Merged
beyondkmp merged 6 commits intoelectron-userland:masterfrom Apr 12, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 99af642 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ojectDir parameter
mmaietta
reviewed
Apr 11, 2025
mmaietta
approved these changes
Apr 11, 2025
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #9011
Under the two
package.jsonframework, if there are nonode_modulesin theappdirectory andnpmRebuildis set tofalse, dependencies will not be reinstalled. As a result,npm listwill return empty. In this case, we should attempt to retrieve thenode_modulesusing theprojectDir, which can resolve this issue.Using

getProjectRootPathdirectly fromelectron/rebuildis not accurate because it recursively searches upward level by level and returns the first match it finds. If I set theappdirectory outside theproject dir, such as in another directory, the result returned bygetProjectRootPathinelectron/rebuildwill be incorrect. Therefore, theprojectDirshould be passed in directly instead of searching upward level by level.https://github.com/electron/rebuild/blob/ff1ec40f82ca64e014079b246053f039b3cf4f23/src/search-module.ts#L76-L86