Skip to content

chore(monorepo): bump electron-builder to 26.0.15#18445

Merged
mjhuff merged 3 commits intoedgefrom
mono_bump-electron-builder
May 29, 2025
Merged

chore(monorepo): bump electron-builder to 26.0.15#18445
mjhuff merged 3 commits intoedgefrom
mono_bump-electron-builder

Conversation

@mjhuff
Copy link
Copy Markdown
Contributor

@mjhuff mjhuff commented May 28, 2025

Overview

Bumps electron-builder to 26.0.15 in anticipation of some future app key signing changes and arm64 build work. This PR is intended to be a non-functional bump.

A couple notes:

  • The shape of electron-builder-config.js has changed in this major version bump. I used these docs to update the config. Nothing "functional" here.
  • The latest version of electron-builder is actually 26.0.12. 26.0.15 is the next tagged version. Unfortunately, we encounter this exact bug outlined here in the latest tag release, so we need to bump past .12.
  • For some totally unknown reason, after building the app, launching it would encounter a main process error:
Uncaught Exception:
Error: Cannot find module 'agent-base'

Adding agent-base as an explicit dependency solves the issue. I'm guessing electron-builder 26 more aggressively tree-shakes or does module resolution/bundling a bit differently.

Test Plan and Hands on Testing

  • The app runs and builds locally
  • The odd runs on a robot
  • A version built on CI runs.

Changelog

  • Bumped electron-builder to 26.0.15.

Review requests

  • Are we ok with explictly specifying agent-base as a dependency of app-shell

Risk assessment

  • I think if all the test cases and CI pass, we should be in a good spot.

@mjhuff mjhuff requested review from sfoster1 and y3rsh May 28, 2025 20:36
@mjhuff mjhuff requested review from a team as code owners May 28, 2025 20:36
@mjhuff mjhuff requested review from smb2268 and removed request for a team May 28, 2025 20:36
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 58.00%. Comparing base (5758c4e) to head (d33eadd).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
app-shell/electron-builder.config.js 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             edge   #18445       +/-   ##
===========================================
+ Coverage   25.16%   58.00%   +32.84%     
===========================================
  Files        3254     3254               
  Lines      277287   277361       +74     
  Branches    32249    32357      +108     
===========================================
+ Hits        69772   160887    +91115     
+ Misses     207492   116279    -91213     
- Partials       23      195      +172     
Flag Coverage Δ
protocol-designer 19.39% <0.00%> (-0.01%) ⬇️
step-generation 4.60% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app-shell/electron-builder.config.js 0.00% <0.00%> (ø)

... and 1663 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mjhuff mjhuff requested review from koji and removed request for smb2268 May 28, 2025 20:37
@mjhuff mjhuff force-pushed the mono_bump-electron-builder branch from ca0b9bd to 12b9197 Compare May 28, 2025 20:39
@mjhuff
Copy link
Copy Markdown
Contributor Author

mjhuff commented May 28, 2025

Will retry building the app once #18446 merges. FE tests failing.

@koji
Copy link
Copy Markdown
Contributor

koji commented May 28, 2025

the changes look good to me. (aligned with the doc you shared).
Josh (@y3rsh ) is working on Windows signing so probably getting his approval would be important.
from the repo, agent-base is for testing so as you said it would be related to their build config 🤣

@mjhuff
Copy link
Copy Markdown
Contributor Author

mjhuff commented May 29, 2025

#18449 should fix the CI issues, will re-run CI after that merges

Copy link
Copy Markdown
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mjhuff mjhuff merged commit df970fe into edge May 29, 2025
60 of 61 checks passed
@mjhuff mjhuff deleted the mono_bump-electron-builder branch May 29, 2025 13:16
ddcc4 pushed a commit that referenced this pull request May 29, 2025
ddcc4 pushed a commit that referenced this pull request May 29, 2025
ddcc4 pushed a commit that referenced this pull request May 29, 2025
ddcc4 pushed a commit that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants