chore(monorepo): bump electron-builder to 26.0.15#18445
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #18445 +/- ##
===========================================
+ Coverage 25.16% 58.00% +32.84%
===========================================
Files 3254 3254
Lines 277287 277361 +74
Branches 32249 32357 +108
===========================================
+ Hits 69772 160887 +91115
+ Misses 207492 116279 -91213
- Partials 23 195 +172
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ca0b9bd to
12b9197
Compare
|
Will retry building the app once #18446 merges. FE tests failing. |
|
the changes look good to me. (aligned with the doc you shared). |
|
#18449 should fix the CI issues, will re-run CI after that merges |
y3rsh
left a comment
There was a problem hiding this comment.
I tested Windows,Mac, and Linux apps built in CI and they all work.
Mac build: https://builds.opentrons.com/app/Opentrons-v8.4.0-mac-b56686-mono_bump-electron-builder-app-build.dmg
Windows build: https://builds.opentrons.com/app/Opentrons-v8.4.0-win-b56686-mono_bump-electron-builder-app-build.exe
Linux build: https://builds.opentrons.com/app/Opentrons-v8.4.0-linux-b56686-mono_bump-electron-builder-app-build.AppImage
This was from https://github.com/Opentrons/opentrons/tree/mono_bump-electron-builder-app-build
(cherry picked from commit df970fe)
(cherry picked from commit df970fe)
(cherry picked from commit df970fe)
(cherry picked from commit df970fe)
Overview
Bumps electron-builder to 26.0.15 in anticipation of some future app key signing changes and arm64 build work. This PR is intended to be a non-functional bump.
A couple notes:
electron-builder-config.jshas changed in this major version bump. I used these docs to update the config. Nothing "functional" here.nexttagged version. Unfortunately, we encounter this exact bug outlined here in thelatesttag release, so we need to bump past .12.Adding agent-base as an explicit dependency solves the issue. I'm guessing electron-builder 26 more aggressively tree-shakes or does module resolution/bundling a bit differently.
Test Plan and Hands on Testing
Changelog
Review requests
agent-baseas a dependency ofapp-shellRisk assessment