Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing html extension for multi language license files in nsis target #7339

Merged
merged 2 commits into from
Jan 3, 2023

Conversation

zanzara
Copy link
Contributor

@zanzara zanzara commented Dec 25, 2022

Regarding issue #7334
#7334
there was missing the .html extension.

@changeset-bot
Copy link

changeset-bot bot commented Dec 25, 2022

🦋 Changeset detected

Latest commit: 80e9f59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Dec 25, 2022

Deploy Preview for car-park-attendant-cleat-11576 ready!

Name Link
🔨 Latest commit 80e9f59
🔍 Latest deploy log https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/63af1590462adf000919690f
😎 Deploy Preview https://deploy-preview-7339--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zanzara zanzara changed the title missing html extension for multi language license files in nsis target fix: missing html extension for multi language license files in nsis target Dec 25, 2022
@mmaietta mmaietta merged commit 8f94978 into electron-userland:master Jan 3, 2023
@vvillaluna
Copy link

Hey guys from which version it will be added ?

@mmaietta
Copy link
Collaborator

@vvillaluna 24.0.0-alpha.9

@vvillaluna
Copy link

vvillaluna commented Jan 24, 2023

What's the difference in the process of reading the license file when using the multiLanguage and adding them directly on license nsis config ?

Seems like it has differences in the output,

Using license: "license_ja.html" works well.
image

But using multilanguage like putting licenses under build resources is not working properly html tags were included:
image

@mmaietta can you guide me where to check that functionality would like to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants