Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS Multi Language License File support does not work #7334

Closed
zanzara opened this issue Dec 23, 2022 · 3 comments
Closed

NSIS Multi Language License File support does not work #7334

zanzara opened this issue Dec 23, 2022 · 3 comments

Comments

@zanzara
Copy link
Contributor

zanzara commented Dec 23, 2022

  • Electron-Builder Version: 23.6.0
  • Node Version: 16.16.0
  • Electron Version: 21.1.0
  • Electron Type (current, beta, nightly): current
  • Target: Windows10 64bit

I have multiple license files as license_en.html and license_de.html i.e.
but it doesn't matter in which folder I put them, the installer setup.exe will never show them.

If i put the license prop directly to one license file location as ie.
license: license_en.html
it works.

So I assume, that this feature does not work as described in the electron-builder docs under
https://www.electron.build/configuration/nsis

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
@ielektronick
Copy link

I do understand that the issue is closed more than a year ago, but still.

According to app-builder-lib package source code, the license files could be placed in root on build resources (https://www.electron.build/nsis#license), meaning if you put the license files (license_de.txt, license_en.txt etc) to the root and run electron-builder to make nsis installer, the files should be handled accordingly.

To check it, after the installer script review the builder-debug.yml file. There should be something like:

!macro licensePage
  LicenseLangString MUILicense 1033 "path\build\license_en.txt"
  LicenseLangString MUILicense 1031 "path\build\license_de.txt"
  !insertmacro MUI_PAGE_LICENSE "$(MUILicense)"
!macroend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants