Merged
Conversation
|
Documentation previews: |
benironside
requested review from
banderror,
caitlinbetz,
dhurley14,
jmikell821,
joepeeples,
kqualters-elastic,
michaelolo24 and
nastasha-solomon
Member
|
@benironside I added the new
Feel free to ignored this if you've already discussed adding/not adding these PRs with the Cloud Security team. |
Member
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Thanks for putting these together, @benironside!
Contributor
Author
No, this is great, I was thinking about this on Friday and thank you for updating that config file. Will get these added! |
joepeeples
reviewed
May 22, 2023
Contributor
joepeeples
left a comment
joepeeples
left a comment
There was a problem hiding this comment.
Looking good, added a few edits, thanks!
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
jmikell821
reviewed
May 22, 2023
Member
jmikell821
left a comment
jmikell821
left a comment
There was a problem hiding this comment.
These look great! Just some minor suggestions. Thanks @benironside and @nastasha-solomon 🌟
…stic/security-docs into issue-3139-8.8-release-notes
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
benironside
commented
May 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 25, 2023
* starts draft, creates new page * ports changes to this branch from another branch * Finish bug fixes section * Adds a feature * fixes build error * Updating known issues * Adding breaking changes * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc * Update docs/release-notes/8.8.asciidoc * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Adding delete api bugfix * incorporates Janeen's feedback and minor edits * throttle field deprecation summary * Various edits, incorporates feedback * adds cloud features * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc --------- Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 4a07bed)
benironside
added a commit
that referenced
this pull request
May 25, 2023
* starts draft, creates new page * ports changes to this branch from another branch * Finish bug fixes section * Adds a feature * fixes build error * Updating known issues * Adding breaking changes * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc * Update docs/release-notes/8.8.asciidoc * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Joe Peeples <joe.peeples@elastic.co> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Adding delete api bugfix * incorporates Janeen's feedback and minor edits * throttle field deprecation summary * Various edits, incorporates feedback * adds cloud features * Update docs/release-notes/8.8.asciidoc Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> * Update docs/release-notes/8.8.asciidoc --------- Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co> Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com> Co-authored-by: Joe Peeples <joe.peeples@elastic.co> (cherry picked from commit 4a07bed) Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
banderror
reviewed
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3139 and #3143 by publishing release notes for 8.8
Preview