[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table#154388
Merged
opauloh merged 38 commits intoelastic:mainfrom Apr 12, 2023
Merged
[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table#154388opauloh merged 38 commits intoelastic:mainfrom
opauloh merged 38 commits intoelastic:mainfrom
Conversation
x-pack/plugins/cloud_security_posture/public/components/vulnerability_badges.tsx
Show resolved
Hide resolved
...configurations/latest_findings_by_resource/resource_findings/resource_findings_container.tsx
Show resolved
Hide resolved
...ins/cloud_security_posture/public/pages/vulnerabilities/hooks/use_latest_vulnerabilities.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/utils.ts
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities.tsx
Outdated
Show resolved
Hide resolved
| score: float; | ||
| version: CVSSVersion; | ||
| color: string; | ||
| version?: string; |
Contributor
There was a problem hiding this comment.
why would a vulnerability score badge have a score but not have a version?
x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities.tsx
Outdated
Show resolved
Hide resolved
opauloh
commented
Apr 10, 2023
x-pack/plugins/cloud_security_posture/server/create_indices/create_indices.ts
Outdated
Show resolved
Hide resolved
| <h2> | ||
| <FormattedMessage | ||
| id="xpack.csp.findings.resourceFindings.noFindingsTitle" | ||
| defaultMessage="There are no Findings" |
Contributor
There was a problem hiding this comment.
Nit: Findings are generic for configurations or vulnerabilities. Maybe here we can be more specific with There are no vulnerabilities. This probably needs a second opinion from the product
Contributor
|
@opauloh if update your PR with the latest changes from Master. The FTR test will be fixed. |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket: #150510
This PR adds the Vulnerability Management table to the Findings page - Vulnerabilities tab. It also
logs-cloud_security_posture.vulnerabilities-latest.This PR also added two new hooks:
logs-*and filters the fields to narrow to a specific index pattern. This allows us to have a search bar and filter working without the need to create a Data View.Todo: Add tests for the vulnerability table
Screenshots
Initial State
Filtering
Empty State (Sharing component with Configurations tab)
Sorting
