Skip to content

[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table#154388

Merged
opauloh merged 38 commits intoelastic:mainfrom
opauloh:vuln/table
Apr 12, 2023
Merged

[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table#154388
opauloh merged 38 commits intoelastic:mainfrom
opauloh:vuln/table

Conversation

@opauloh
Copy link
Copy Markdown
Contributor

@opauloh opauloh commented Apr 4, 2023

Summary

Ticket: #150510

This PR adds the Vulnerability Management table to the Findings page - Vulnerabilities tab. It also

  • Fetches results from the logs-cloud_security_posture.vulnerabilities-latest.
  • Uses EuiGrid component
  • Has sorting and pagination controls (it shares page size state with configurations findings)
  • All columns except the Actions column are sortable
  • Items per page to default to 10, with options of 10, 25, 100
  • Add an Empty results message in case of no results

This PR also added two new hooks:

  • useCloudPostureTable: Hook for managing common table state and methods for Cloud Posture
  • useDataViewForIndexPattern: Hook that extracts data view from the common logs-* and filters the fields to narrow to a specific index pattern. This allows us to have a search bar and filter working without the need to create a Data View.

Todo: Add tests for the vulnerability table

Screenshots

Initial State

image

Filtering

image

image

image

Empty State (Sharing component with Configurations tab)

image

Sorting
image

@opauloh opauloh added the release_note:feature Makes this part of the condensed release notes label Apr 4, 2023
score: float;
version: CVSSVersion;
color: string;
version?: string;
Copy link
Copy Markdown
Contributor

@Omolola-Akinleye Omolola-Akinleye Apr 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would a vulnerability score badge have a score but not have a version?

<h2>
<FormattedMessage
id="xpack.csp.findings.resourceFindings.noFindingsTitle"
defaultMessage="There are no Findings"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Findings are generic for configurations or vulnerabilities. Maybe here we can be more specific with There are no vulnerabilities. This probably needs a second opinion from the product

@Omolola-Akinleye Omolola-Akinleye self-requested a review April 11, 2023 16:20
Copy link
Copy Markdown
Contributor

@Omolola-Akinleye Omolola-Akinleye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@opauloh opauloh enabled auto-merge (squash) April 11, 2023 22:07
@Omolola-Akinleye
Copy link
Copy Markdown
Contributor

Omolola-Akinleye commented Apr 12, 2023

@opauloh if update your PR with the latest changes from Master. The FTR test will be fixed.

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Apr 12, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cloudSecurityPosture 148 157 +9

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 167.9KB 174.4KB +6.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudSecurityPosture 11.4KB 11.5KB +135.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 433 436 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@opauloh opauloh merged commit e546d52 into elastic:main Apr 12, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:feature Makes this part of the condensed release notes Team:Cloud Security Cloud Security team related v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloud Security] [Findings] [Vulnerabilities] Vulnerabilities Table

6 participants