Skip to content

Session view and k8s dashboard fixes#154982

Merged
mitodrummer merged 21 commits intoelastic:mainfrom
mitodrummer:session_view_and_k8s_fixes
Apr 17, 2023
Merged

Session view and k8s dashboard fixes#154982
mitodrummer merged 21 commits intoelastic:mainfrom
mitodrummer:session_view_and_k8s_fixes

Conversation

@mitodrummer
Copy link
Copy Markdown
Contributor

@mitodrummer mitodrummer commented Apr 14, 2023

Summary

  • fixes some issues in session_view wrt to logs-cloud_defend.process* data.
  • added a 'collapse all' children feature. with sticky scroll session leader!
  • k8s dashboard session table: user.name -> user.id (id is more likely to be set for both endpoint and cloud-defend)
  • Fixed a major bug when 'searching within terminal'. If a process is highlighted it would cause kibana to blow up.
  • session view handling of session leader user info improved.
  • codeowners updated. awp-viz -> sec-cloudnative-integrations
  • a badge will be added to the selector header when it's not in used by a response flow

Screenshots

image

Sticky session leader demo:
https://www.loom.com/share/b039e48fdfd647b291f293d643339660

Checklist

Delete any items that are not applicable to this PR.

@mitodrummer mitodrummer marked this pull request as ready for review April 15, 2023 17:02
@mitodrummer mitodrummer requested a review from a team April 15, 2023 17:02
@mitodrummer mitodrummer added release_note:fix v8.8.0 bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result labels Apr 15, 2023
@mitodrummer mitodrummer requested a review from opauloh April 15, 2023 17:38
@mitodrummer mitodrummer changed the title Session view and k8s fixes Session view and k8s dashboard fixes Apr 15, 2023
@mitodrummer mitodrummer requested a review from a team April 17, 2023 16:31
@mitodrummer mitodrummer requested a review from animehart April 17, 2023 20:22
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #56 / cases security and spaces enabled: basic Common delete_comment alerts security_solution should delete the case ID from the alert schema when the user has read access to the kibana feature but no read access to the ES index
  • [job] [logs] FTR Configs #32 / discover feature controls discover feature controls security no discover privileges "before all" hook for "shows 403"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudDefend 256.4KB 256.5KB +46.0B
securitySolution 15.9MB 15.9MB +3.0B
sessionView 384.1KB 385.0KB +836.0B
total +885.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 432 435 +3

Total ESLint disabled count

id before after diff
securitySolution 512 515 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mitodrummer mitodrummer merged commit 0a5b423 into elastic:main Apr 17, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Apr 17, 2023
@KOTungseth KOTungseth added the Team:Cloud Security Cloud Security team related label Apr 26, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result release_note:fix Team:Cloud Security Cloud Security team related v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants