ES|QL - so_vector knn function update#850
Merged
carlosdelest merged 2 commits intomasterfrom Sep 12, 2025
Merged
Conversation
ioanatia
approved these changes
Sep 11, 2025
Member
Author
|
@elasticmachine test this please |
NickDris
added a commit
to NickDris/rally-tracks
that referenced
this pull request
Sep 15, 2025
* Implement KNN comparison with ESQL for so_vector (elastic#837) Update the so_vector rally track to also exercise knn against the ESQL frontend. * Add patterned_text_index_options parameter (elastic#840) Add patterned_text_index_options parameter to elastic/log tracks. Can accepts value of docs and positions, defaults to docs. Sets the index_options value of the message field in all indices. Only applies if patterned_text_message_field is set to true, and message fields are patterned_text, rather than match_only_text. * Fix so_vector for serverless operator (elastic#844) Misplaced comma * ES|QL: Add queries for LOOKUP JOIN with multiple join keys (elastic#838) * Add a few runtime fields to insist-chicken challenge (elastic#841) * Add elastic/logs patterned-text queries challenge (elastic#842) Add challenge which queries message field with several term and phrase queries. This is meant to test the patterned_text mapping type, but can also be used to test match_only_text message fields. * Reduce number of iterations for queries that use runtime fields. (elastic#846) * Remove routing_path from tsdb index template (elastic#847) Setting this is not necessary as the routing path is set automatically for data streams and this template defines `"data_stream": {}`. It would also prevent an optimization added in elastic/elasticsearch#132566. * Set index template for ingest_mode: data_stream (elastic#849) Rolls back changes in elastic#722 that broke the `ingest_mode: data_stream`. * ES|QL - so_vector knn function update (elastic#850) * Add missing p_index_mode param (elastic#853) --------- Co-authored-by: Svilen Mihaylov <svilen.mihaylov@elastic.co> Co-authored-by: Parker Timmins <parker.timmins@elastic.co> Co-authored-by: Evgenia Badiyanova <evgenia.badiyanova@elastic.co> Co-authored-by: Luigi Dell'Aquila <luigi.dellaquila@gmail.com> Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com> Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
jilldoty-elastic
removed the request for review
from svilen-mihaylov-elastic
esbenchmachine
added
the
backport pending
Collaborator
|
@carlosdelest
Backporting entails:
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNN function changed its signature because of elastic/elasticsearch#132944.
Now KNN uses the following syntax:
This PR updates the so_vector track to use the new KNN format.
Plus, it fixes a small parameter issue - the
esql_enabledtrack param is now a boolean instead of a String.