Introduce a new operation to benchmark the shard changes recovery api#722
Merged
salvatore-campagna merged 39 commits intoelastic:masterfrom Jan 22, 2025
Conversation
martijnvg
reviewed
Jan 15, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Thanks Salvatore! I left a comment about inlining shard-recovery in existing challenge.
Member
|
@elasticmachine update branch |
martijnvg
approved these changes
Jan 15, 2025
salvatore-campagna
changed the title
martijnvg
reviewed
Jan 22, 2025
Member
There was a problem hiding this comment.
I don't think we need to these operations related to merging? It just makes this challenge run longer?
Member
There was a problem hiding this comment.
I think we can remove force-merge and wait-until-merges-finish here?
felixbarny
added a commit
that referenced
this pull request
Sep 10, 2025
Rolls back changes in #722 that broke the `ingest_mode: data_stream`.
felixbarny
added a commit
that referenced
this pull request
Sep 12, 2025
Rolls back changes in #722 that broke the `ingest_mode: data_stream`.
NickDris
added a commit
to NickDris/rally-tracks
that referenced
this pull request
Sep 15, 2025
* Implement KNN comparison with ESQL for so_vector (elastic#837) Update the so_vector rally track to also exercise knn against the ESQL frontend. * Add patterned_text_index_options parameter (elastic#840) Add patterned_text_index_options parameter to elastic/log tracks. Can accepts value of docs and positions, defaults to docs. Sets the index_options value of the message field in all indices. Only applies if patterned_text_message_field is set to true, and message fields are patterned_text, rather than match_only_text. * Fix so_vector for serverless operator (elastic#844) Misplaced comma * ES|QL: Add queries for LOOKUP JOIN with multiple join keys (elastic#838) * Add a few runtime fields to insist-chicken challenge (elastic#841) * Add elastic/logs patterned-text queries challenge (elastic#842) Add challenge which queries message field with several term and phrase queries. This is meant to test the patterned_text mapping type, but can also be used to test match_only_text message fields. * Reduce number of iterations for queries that use runtime fields. (elastic#846) * Remove routing_path from tsdb index template (elastic#847) Setting this is not necessary as the routing path is set automatically for data streams and this template defines `"data_stream": {}`. It would also prevent an optimization added in elastic/elasticsearch#132566. * Set index template for ingest_mode: data_stream (elastic#849) Rolls back changes in elastic#722 that broke the `ingest_mode: data_stream`. * ES|QL - so_vector knn function update (elastic#850) * Add missing p_index_mode param (elastic#853) --------- Co-authored-by: Svilen Mihaylov <svilen.mihaylov@elastic.co> Co-authored-by: Parker Timmins <parker.timmins@elastic.co> Co-authored-by: Evgenia Badiyanova <evgenia.badiyanova@elastic.co> Co-authored-by: Luigi Dell'Aquila <luigi.dellaquila@gmail.com> Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com> Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com> Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
NickDris
pushed a commit
that referenced
this pull request
Oct 23, 2025
NickDris
pushed a commit
to NickDris/rally-tracks
that referenced
this pull request
Dec 19, 2025
Rolls back changes in elastic#722 that broke the `ingest_mode: data_stream`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PR elastic/elasticsearch#118608, we introduced a new API that we would like to benchmark in order to evaluate the latency of synthetic source recovery. This benchmarking will help us assess how the API latency evolves over time and understand the potential impact of new features on recovery latency. The targets for this benchmark will include indices or data streams in the
elastic/logs,elastic/security, andtsdbtracks.Retention Lease Requirement:
It is important to add a retention lease before starting document indexing. This is necessary for ensuring that the subsequent shard recovery API call executes successfully without missing
seq_novalues. A missing retention lease may result in missingseq_novalues during shard recovery.Support for Data Streams and Index Aliases:
We extended the original API in PR elastic/elasticsearch#118937 to support data streams and index aliases. This extension is necessary for data stream use cases, as the backing index name may change depending on when the index is created. Supporting data streams and aliases simplifies benchmarking and provides greater flexibility in targeting indices.