Skip to content

Remove routing_path from tsdb index template#847

Merged
felixbarny merged 1 commit intomasterfrom
remove-routing-path
Sep 9, 2025
Merged

Remove routing_path from tsdb index template#847
felixbarny merged 1 commit intomasterfrom
remove-routing-path

Conversation

@felixbarny
Copy link
Member

Setting this is not necessary as the routing path is set automatically for data streams and this template defines "data_stream": {}. It would also prevent an optimization added in elastic/elasticsearch#132566.

Setting this is not necessary as the routing path is set automatically for data streams and this template defines `"data_stream": {}`. It would also prevent an optimization added in elastic/elasticsearch#132566.
Copy link
Member

@gareth-ellis gareth-ellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fyi @AI-IshanBhatt

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixbarny felixbarny merged commit 04b3707 into master Sep 9, 2025
23 of 24 checks passed
@felixbarny felixbarny deleted the remove-routing-path branch September 9, 2025 20:25
NickDris added a commit to NickDris/rally-tracks that referenced this pull request Sep 15, 2025
* Implement KNN comparison with ESQL for so_vector (elastic#837)

Update the so_vector rally track to also exercise knn against the ESQL frontend.

* Add patterned_text_index_options parameter (elastic#840)

Add patterned_text_index_options parameter to elastic/log tracks. Can accepts value of docs and positions, defaults to docs. Sets the index_options value of the message field in all indices. Only applies if patterned_text_message_field is set to true, and message fields are patterned_text, rather than match_only_text.

* Fix so_vector for serverless operator (elastic#844)

Misplaced comma

* ES|QL: Add queries for LOOKUP JOIN with multiple join keys (elastic#838)

* Add a few runtime fields to insist-chicken challenge (elastic#841)

* Add elastic/logs patterned-text queries challenge (elastic#842)

Add challenge which queries message field with several term and phrase queries. This is meant to test the patterned_text mapping type, but can also be used to test match_only_text message fields.

* Reduce number of iterations for queries that use runtime fields. (elastic#846)

* Remove routing_path from tsdb index template (elastic#847)

Setting this is not necessary as the routing path is set automatically for data streams and this template defines `"data_stream": {}`. It would also prevent an optimization added in elastic/elasticsearch#132566.

* Set index template for ingest_mode: data_stream (elastic#849)

Rolls back changes in elastic#722 that broke the `ingest_mode: data_stream`.

* ES|QL - so_vector knn function update (elastic#850)

* Add missing p_index_mode param (elastic#853)

---------

Co-authored-by: Svilen Mihaylov <svilen.mihaylov@elastic.co>
Co-authored-by: Parker Timmins <parker.timmins@elastic.co>
Co-authored-by: Evgenia Badiyanova <evgenia.badiyanova@elastic.co>
Co-authored-by: Luigi Dell'Aquila <luigi.dellaquila@gmail.com>
Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com>
Co-authored-by: Felix Barnsteiner <felixbarny@users.noreply.github.com>
Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
@esbenchmachine esbenchmachine added the backport pending Awaiting backport to stable release branch label Dec 19, 2025
@esbenchmachine
Copy link
Collaborator

@felixbarny
A backport is pending for this PR. Please add all required vX.Y version labels.

  • If it is intended for the current Elasticsearch release version, apply the corresponding version label.
  • If it also supports past released versions, add those labels too.
  • If it only targets a future version, wait until that version label exists and then add it.
    (Each rally-tracks version label is created during the feature freeze of a new Elasticsearch branch).

Backporting entails:

  1. Ensure the correct version labels exist in this PR.
  2. Ensure backport PRs have backport label and are passing tests.
  3. Merge backport PRs (you can approve yourself and enable auto-merge).
  4. Remove backport pending label from this PR once all backport PRs are merged.

Thank you!

@felixbarny
Copy link
Member Author

No idea if/why/what to do wrt. backporting here tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport pending Awaiting backport to stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments