Skip to content

Profiling: add data stream type#503

Merged
jsoriano merged 6 commits intomainfrom
profiling/stream-type
Apr 20, 2023
Merged

Profiling: add data stream type#503
jsoriano merged 6 commits intomainfrom
profiling/stream-type

Conversation

@inge4pres
Copy link
Copy Markdown
Contributor

@inge4pres inge4pres commented Apr 19, 2023

  • data-streams: add profiling type
  • test case for profiling data streams

What does this PR do?

We add a new data stream type profiling to allow creating dedicated data streams for Universal Profiling.

Why is it important?

We are going to use it in Cloud for the Universal Profiling symbolization service.

Checklist

Related issues

inge4pres added 2 commits April 19, 2023 11:50
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres inge4pres requested a review from a team as a code owner April 19, 2023 10:17
@inge4pres inge4pres requested review from joshdover and jsoriano April 19, 2023 10:17
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 19, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-19T15:21:48.308+0000

  • Duration: 8 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 762
Skipped 0
Total 762

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 70.37% (19/27) 👍
Classes 77.778% (28/36) 👍
Methods 55.172% (64/116) 👍
Lines 42.479% (593/1396) 👍
Conditionals 100.0% (0/0) 💚

@inge4pres inge4pres self-assigned this Apr 19, 2023
Copy link
Copy Markdown
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a discussion about using the new profiling vs. the existing traces, and there it was also commented that this kind of event-like data would also fit in the logs type.

The main point of the discussion was to avoid having too many types of data streams.

Has there been some decision around this? Is it confirmed that logs cannot be used?

@inge4pres
Copy link
Copy Markdown
Contributor Author

Has there been some decision around this? Is it confirmed that logs cannot be used?

I think so.

There is really no point in naming logs the profiling data.

@jsoriano
Copy link
Copy Markdown
Member

Change looks good, will wait for @joshdover and @kpollich regarding the addition of the new type and its implications.

kpollich
kpollich previously approved these changes Apr 19, 2023
@kpollich
Copy link
Copy Markdown
Member

Change looks good, will wait for @joshdover and @kpollich regarding the addition of the new type and its implications.

All good on my end.

Comment thread spec/integration/data_stream/manifest.spec.yml
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants