Skip to content

universal_profiling_symbolizer: add data stream#5971

Closed
inge4pres wants to merge 2 commits intomainfrom
profiling/symbol-data-stream
Closed

universal_profiling_symbolizer: add data stream#5971
inge4pres wants to merge 2 commits intomainfrom
profiling/symbol-data-stream

Conversation

@inge4pres
Copy link
Copy Markdown
Contributor

@inge4pres inge4pres commented Apr 24, 2023

What does this PR do?

Adds a data stream to universal_profiling_symbolizer package.
It makes use of the new profiling data stream type created in elastic/package-spec#503 so it needs the format_version to be bumped.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

Create a deployment in Elastic Cloud, install the package with elastic-package and verify the data stream is created.

Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@inge4pres inge4pres requested a review from florianl April 24, 2023 08:25
@inge4pres inge4pres self-assigned this Apr 24, 2023
Signed-off-by: inge4pres <francesco.gualazzi@elastic.co>
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 24, 2023

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-24T08:27:05.254+0000

  • Duration: 12 min 50 sec

Steps errors 4

Expand to view the steps failures

Check integration: universal_profiling_symbolizer
  • Took 0 min 0 sec . View more details here
  • Description: ../../build/elastic-package check -v
Take down the Elastic stack
  • Took 0 min 0 sec . View more details here
  • Description: build/elastic-package stack down -v
Google Storage Download
  • Took 0 min 0 sec . View more details here
Google Storage Download
  • Took 0 min 0 sec . View more details here

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@botelastic
Copy link
Copy Markdown

botelastic Bot commented May 24, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic Bot added the Stalled label May 24, 2023
@florianl
Copy link
Copy Markdown
Member

florianl commented Jun 1, 2023

I think we can close this? @inge4pres

@botelastic botelastic Bot removed the Stalled label Jun 1, 2023
@inge4pres inge4pres closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants